-
Notifications
You must be signed in to change notification settings - Fork 791
SOLR-18005 move to jetty package and rename #3901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SOLR-18005 move to jetty package and rename #3901
Conversation
epugh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I scanned, and while I don't love the use of var, that is just me. The doc changes looked good. And the overall change looks good.
dsmiley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added var systematically for HttpJettySolrClient (or via its Builder) for the case of calling a constructor to initialize it. So it's type is obvious, in theory, albeit I didn't look at every single line. Do you find the type unclear anywhere @epugh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @jdyer1 ... even though HttpClusterStateProvider is exists in the apache package in the test framework, it will be removed, freeing up this name for use here.
| */ | ||
| public abstract ConcurrentUpdateBaseSolrClient build(); | ||
|
|
||
| public HttpSolrClientBase getClient() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed occasional getters to expose things that are now in different packages and thus not exposed. A protected field on a builder isn't accessible to the class being constructed that uses the builder, if it's in another package.
I think for me it's just a stylistic thing that twenty years of Java typing has leaned me against! In ruby it is all vars ;-) |
|
I'm planning on merging this one late tonight or tomorrow morning. |
https://issues.apache.org/jira/browse/SOLR-18005
Moving jetty client stuff to the jetty package, that haven't yet moved there.
Renamed Http2SolrClient to HttpJettySolrClient.
CloudJettySolrClient added, and enhanced CloudHttp2SolrClient to detect if Jetty is available and to use that client if it is -- (same code here as provided in #3852)
Move CloudHttp2SolrClient.Builder to CloudSolrClient. There's now barely any references to CloudHttp2SolrClient. We'll probably remove that someday. I marked it as internal.
This'll be tough to review due to rename noise... I think it's boring honestly but the changes in the impl & jetty packages could be reviewed.