Skip to content

Commit 081edfd

Browse files
committed
[SPARK-53404] Make Build step to verify test compilation too
### What changes were proposed in this pull request? This PR aims to make `Build` step to verify test compilation too. ### Why are the changes needed? Like Apache Spark main repo, SPARK-53376 added the `Build` step before running the actual test. - #222 However, it turns out that the test code building is not verified correctly. So, this PR aims to use the following workaround to verify test code fully without running any test. ```yaml - run: swift build -c release + run: swift test --filter NOTHING -c release ``` In addition, this reduces the total runtime of CIs like the following example. - BEFORE: 13m 43s - https://github.com/apache/spark-connect-swift/actions/runs/17244668737/job/48932508796 - AFTER: 11m 35s - https://github.com/apache/spark-connect-swift/actions/runs/17252163531/job/48956652819?pr=225 ### Does this PR introduce _any_ user-facing change? No. This is a test infra change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #225 from dongjoon-hyun/BUILD_TEST_CODE. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent ab5df6c commit 081edfd

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.github/workflows/build_and_test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ jobs:
123123
with:
124124
swift-version: "6.1"
125125
- name: Build
126-
run: swift build -c release
126+
run: swift test --filter NOTHING -c release
127127
- name: Test
128128
run: |
129129
curl -LO https://dist.apache.org/repos/dist/dev/spark/v4.1.0-preview1-rc1-bin/spark-4.1.0-preview1-bin-hadoop3.tgz
@@ -145,7 +145,7 @@ jobs:
145145
with:
146146
swift-version: "6.1"
147147
- name: Build
148-
run: swift build -c release
148+
run: swift test --filter NOTHING -c release
149149
- name: Test
150150
run: |
151151
curl -LO https://www.apache.org/dyn/closer.lua/spark/spark-4.0.0/spark-4.0.0-bin-hadoop3.tgz?action=download
@@ -168,7 +168,7 @@ jobs:
168168
with:
169169
swift-version: "6.1"
170170
- name: Build
171-
run: swift build -c release
171+
run: swift test --filter NOTHING -c release
172172
- name: Test
173173
run: |
174174
curl -LO https://www.apache.org/dyn/closer.lua/spark/spark-4.0.0/spark-4.0.0-bin-hadoop3.tgz?action=download
@@ -195,7 +195,7 @@ jobs:
195195
distribution: zulu
196196
java-version: 17
197197
- name: Build
198-
run: swift build -c release
198+
run: swift test --filter NOTHING -c release
199199
- name: Test
200200
run: |
201201
curl -LO https://www.apache.org/dyn/closer.lua/spark/spark-3.5.6/spark-3.5.6-bin-hadoop3.tgz?action=download
@@ -223,7 +223,7 @@ jobs:
223223
distribution: zulu
224224
java-version: 17
225225
- name: Build
226-
run: swift build -c release
226+
run: swift test --filter NOTHING -c release
227227
- name: Test
228228
run: |
229229
curl -LO https://www.apache.org/dyn/closer.lua/spark/spark-3.5.6/spark-3.5.6-bin-hadoop3.tgz?action=download

0 commit comments

Comments
 (0)