Address comment

dongjoon-hyun · dongjoon-hyun · commit a3317d9539c9 · 2025-04-18T15:33:24.000+09:00
diff --git a/Sources/SparkConnect/DataFrame.swift b/Sources/SparkConnect/DataFrame.swift
@@ -573,6 +573,7 @@ public actor DataFrame: Sendable {
       self.plan.root,
       right,
       SetOpType.union,
+      isAll: true,
       byName: true,
       allowMissingColumns: allowMissingColumns
     )
diff --git a/Tests/SparkConnectTests/DataFrameTests.swift b/Tests/SparkConnectTests/DataFrameTests.swift
@@ -445,6 +445,8 @@ struct DataFrameTests {
     let df2 = try await spark.sql("SELECT 4 b, 3 a")
     #expect(try await df1.unionByName(df2).collect() == [Row("1", "2"), Row("3", "4")])
     #expect(try await df1.union(df2).collect() == [Row("1", "2"), Row("4", "3")])
+    let df3 = try await spark.sql("SELECT * FROM VALUES 1, 1")
+    #expect(try await df3.unionByName(df3).count() == 4)
     await spark.stop()
   }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -573,6 +573,7 @@ public actor DataFrame: Sendable {`
`573`	`573`	`self.plan.root,`
`574`	`574`	`right,`
`575`	`575`	`SetOpType.union,`
	`576`	`+ isAll: true,`
`576`	`577`	`byName: true,`
`577`	`578`	`allowMissingColumns: allowMissingColumns`
`578`	`579`	`)`
Original file line number	Diff line number	Diff line change
`@@ -445,6 +445,8 @@ struct DataFrameTests {`
`445`	`445`	`let df2 = try await spark.sql("SELECT 4 b, 3 a")`
`446`	`446`	`#expect(try await df1.unionByName(df2).collect() == [Row("1", "2"), Row("3", "4")])`
`447`	`447`	`#expect(try await df1.union(df2).collect() == [Row("1", "2"), Row("4", "3")])`
	`448`	`+ let df3 = try await spark.sql("SELECT * FROM VALUES 1, 1")`
	`449`	`+ #expect(try await df3.unionByName(df3).count() == 4)`
`448`	`450`	`await spark.stop()`
`449`	`451`	`}`
`450`	`452`	`#endif`