Skip to content

Commit 2d569b6

Browse files
committed
[SPARK-52201] Revisit PMD annotations
### What changes were proposed in this pull request? This PR aims to revisit `PMD` annotations. ### Why are the changes needed? We can remove or reduce the scope. **BEFORE** ``` $ git grep PMD | wc -l 5 ``` **AFTER** ``` $ git grep PMD | wc -l 3 ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #210 from dongjoon-hyun/SPARK-52201. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent 363894c commit 2d569b6

File tree

6 files changed

+3
-6
lines changed

6 files changed

+3
-6
lines changed

config/pmd/ruleset.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
<exclude name="ImplicitFunctionalInterface" />
2727
<exclude name="UnitTestAssertionsShouldIncludeMessage" />
2828
<exclude name="UnitTestContainsTooManyAsserts" />
29-
<exclude name="UnitTestShouldIncludeAssert" />
3029
<exclude name="UnusedLocalVariable" />
3130
<exclude name="LooseCoupling" />
3231
</rule>

spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/sink/MockSink.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
import org.apache.spark.metrics.sink.Sink;
3030

31-
@SuppressWarnings("PMD")
31+
@SuppressWarnings("PMD.UnusedPrivateField")
3232
public class MockSink implements Sink {
3333
private static final Logger logger = LoggerFactory.getLogger(MockSink.class);
3434
private final Properties properties;

spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/source/KubernetesMetricsInterceptorTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949

5050
@EnableKubernetesMockClient(crud = true)
5151
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
52-
@SuppressWarnings("PMD")
5352
@SuppressFBWarnings(
5453
value = {"UWF_UNWRITTEN_FIELD", "NP_UNWRITTEN_FIELD", "UUF_UNUSED_FIELD"},
5554
justification = "Unwritten fields are covered by Kubernetes mock client")

spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ProbeServiceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343

4444
import org.apache.spark.k8s.operator.metrics.healthcheck.SentinelManager;
4545

46-
@SuppressWarnings("PMD.JUnitTestsShouldIncludeAssert")
46+
@SuppressWarnings("PMD.UnitTestShouldIncludeAssert")
4747
@EnableKubernetesMockClient
4848
class ProbeServiceTest {
4949
@Test

spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ReadinessProbeTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
import org.apache.spark.k8s.operator.utils.ProbeUtil;
3939

40-
@SuppressWarnings("PMD.JUnitTestsShouldIncludeAssert")
40+
@SuppressWarnings("PMD.UnitTestShouldIncludeAssert")
4141
class ReadinessProbeTest {
4242
KubernetesClient client;
4343
HttpExchange httpExchange;

spark-operator/src/test/java/org/apache/spark/k8s/operator/reconciler/reconcilesteps/AppInitStepTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
import org.apache.spark.k8s.operator.utils.SparkAppStatusRecorder;
5353

5454
@EnableKubernetesMockClient(crud = true)
55-
@SuppressWarnings("PMD")
5655
@SuppressFBWarnings(
5756
value = {"UWF_UNWRITTEN_FIELD", "NP_UNWRITTEN_FIELD", "UUF_UNUSED_FIELD"},
5857
justification = "Unwritten fields are covered by Kubernetes mock client")

0 commit comments

Comments
 (0)