[SPARK-52201] Revisit PMD annotations

Author: dongjoon-hyun

spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/sink/MockSink.java

@@ -28,7 +28,7 @@
 
 import org.apache.spark.metrics.sink.Sink;
 
-@SuppressWarnings("PMD")
+@SuppressWarnings("PMD.UnusedPrivateField")
 public class MockSink implements Sink {
   private static final Logger logger = LoggerFactory.getLogger(MockSink.class);
   private final Properties properties;

spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/source/KubernetesMetricsInterceptorTest.java

@@ -49,7 +49,6 @@
 
 @EnableKubernetesMockClient(crud = true)
 @TestMethodOrder(MethodOrderer.OrderAnnotation.class)
-@SuppressWarnings("PMD")
 @SuppressFBWarnings(
     value = {"UWF_UNWRITTEN_FIELD", "NP_UNWRITTEN_FIELD", "UUF_UNUSED_FIELD"},
     justification = "Unwritten fields are covered by Kubernetes mock client")

spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ProbeServiceTest.java

@@ -43,7 +43,6 @@
 
 import org.apache.spark.k8s.operator.metrics.healthcheck.SentinelManager;
 
-@SuppressWarnings("PMD.JUnitTestsShouldIncludeAssert")
 @EnableKubernetesMockClient
 class ProbeServiceTest {
   @Test

spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ReadinessProbeTest.java

@@ -37,7 +37,6 @@
 
 import org.apache.spark.k8s.operator.utils.ProbeUtil;
 
-@SuppressWarnings("PMD.JUnitTestsShouldIncludeAssert")
 class ReadinessProbeTest {
   KubernetesClient client;
   HttpExchange httpExchange;

spark-operator/src/test/java/org/apache/spark/k8s/operator/reconciler/reconcilesteps/AppInitStepTest.java

@@ -52,7 +52,6 @@
 import org.apache.spark.k8s.operator.utils.SparkAppStatusRecorder;
 
 @EnableKubernetesMockClient(crud = true)
-@SuppressWarnings("PMD")
 @SuppressFBWarnings(
     value = {"UWF_UNWRITTEN_FIELD", "NP_UNWRITTEN_FIELD", "UUF_UNUSED_FIELD"},
     justification = "Unwritten fields are covered by Kubernetes mock client")