Skip to content

Commit fe2f023

Browse files
committed
Group the new props under 'metrics'
1 parent 7c6e748 commit fe2f023

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

docs/config_properties.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
| spark.kubernetes.operator.metrics.clientMetricsEnabled | Boolean | true | false | Enable KubernetesClient metrics for measuring the HTTP traffic to the Kubernetes API Server. Since the metrics is collected via Okhttp interceptors, can be disabled when opt in customized interceptors. |
3030
| spark.kubernetes.operator.metrics.clientMetricsGroupByResponseCodeEnabled | Boolean | true | false | When enabled, additional metrics group by http response code group(1xx, 2xx, 3xx, 4xx, 5xx) received from API server will be added. Users can disable it when their monitoring system can combine lower level kubernetes.client.http.response.<3-digit-response-code> metrics. |
3131
| spark.kubernetes.operator.metrics.port | Integer | 19090 | false | The port used for checking metrics |
32-
| spark.kubernetes.operator.enablePrometheusTextBasedFormat | Boolean | true | false | Whether or not to enable text-based format for Prometheus 2.0, as recommended by https://prometheus.io/docs/instrumenting/exposition_formats/#text-based-format |
33-
| spark.kubernetes.operator.enableSanitizePrometheusMetricsName | Boolean | true | false | Whether or not to enable automatic name sanitizing for all metrics based on best-practice guide from Prometheus https://prometheus.io/docs/practices/naming/ |
32+
| spark.kubernetes.operator.metrics.enablePrometheusTextBasedFormat | Boolean | true | false | Whether or not to enable text-based format for Prometheus 2.0, as recommended by https://prometheus.io/docs/instrumenting/exposition_formats/#text-based-format |
33+
| spark.kubernetes.operator.metrics.enableSanitizePrometheusMetricsName | Boolean | true | false | Whether or not to enable automatic name sanitizing for all metrics based on best-practice guide from Prometheus https://prometheus.io/docs/practices/naming/ |
3434
| spark.kubernetes.operator.health.probePort | Integer | 19091 | false | The port used for health/readiness check probe status. |
3535
| spark.kubernetes.operator.health.sentinelExecutorPoolSize | Integer | 3 | false | Size of executor service in Sentinel Managers to check the health of sentinel resources. |
3636
| spark.kubernetes.operator.health.sentinelResourceReconciliationDelaySeconds | Integer | 60 | true | Allowed max time(seconds) between spec update and reconciliation for sentinel resources. |

spark-operator/src/main/java/org/apache/spark/k8s/operator/config/SparkOperatorConf.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ public final class SparkOperatorConf {
336336

337337
public static final ConfigOption<Boolean> ENABLE_PROMETHEUS_TEXT_BASED_FORMAT =
338338
ConfigOption.<Boolean>builder()
339-
.key("spark.kubernetes.operator.enablePrometheusTextBasedFormat")
339+
.key("spark.kubernetes.operator.metrics.enablePrometheusTextBasedFormat")
340340
.enableDynamicOverride(false)
341341
.description(
342342
"Whether or not to enable text-based format for Prometheus 2.0, as "
@@ -348,7 +348,7 @@ public final class SparkOperatorConf {
348348

349349
public static final ConfigOption<Boolean> ENABLE_SANITIZED_PROMETHEUS_METRICS_NAME =
350350
ConfigOption.<Boolean>builder()
351-
.key("spark.kubernetes.operator.enableSanitizePrometheusMetricsName")
351+
.key("spark.kubernetes.operator.metrics.enableSanitizePrometheusMetricsName")
352352
.enableDynamicOverride(false)
353353
.description(
354354
"Whether or not to enable automatic name sanitizing for all metrics based on "

0 commit comments

Comments
 (0)