Skip to content

[SPARK-53664] Update updateResponseMetrics to handle valid responses only #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-53664] Update updateResponseMetrics to handle valid responses only #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions .../main/java/org/apache/spark/k8s/operator/metrics/source/KubernetesMetricsInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentHashMap;
Expand Down Expand Up @@ -129,7 +130,7 @@ public void after(
@Override
public CompletableFuture<Boolean> afterFailure(
BasicBuilder builder, HttpResponse<?> response, RequestTags tags) {
updateResponseMetrics(null, System.nanoTime());
requestFailedRateMeter.mark();
return CompletableFuture.completedFuture(false);
}

Expand All @@ -143,7 +144,7 @@ public CompletableFuture<Boolean> afterFailure(
*/
@Override
public void afterConnectionFailure(HttpRequest request, Throwable failure) {
updateResponseMetrics(null, System.nanoTime());
requestFailedRateMeter.mark();
}

/**
Expand Down Expand Up @@ -181,16 +182,13 @@ private void updateRequestMetrics(HttpRequest request) {
}

private void updateResponseMetrics(HttpResponse response, long startTimeNanos) {
Objects.requireNonNull(response);
final long latency = System.nanoTime() - startTimeNanos;
if (response != null) {
this.responseRateMeter.mark();
this.responseLatency.update(latency);
getMeterByResponseCode(response.code()).mark();
if (KUBERNETES_CLIENT_METRICS_GROUP_BY_RESPONSE_CODE_GROUP_ENABLED.getValue()) {
responseCodeGroupMeters.get(response.code() / 100 - 1).mark();
}
} else {
this.requestFailedRateMeter.mark();
responseRateMeter.mark();
responseLatency.update(latency);
getMeterByResponseCode(response.code()).mark();
if (KUBERNETES_CLIENT_METRICS_GROUP_BY_RESPONSE_CODE_GROUP_ENABLED.getValue()) {
responseCodeGroupMeters.get(response.code() / 100 - 1).mark();
}
}

Expand Down
Loading