[SPARK-54328] Add configurable startupProbe and enhance liveness/readiness probes in Helm chart #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iness probes in Helm chart ### What changes were proposed in this pull request? This PR adds a configurable `startupProbe` and enhances the existing `livenessProbe` and `readinessProbe` with additional configurable parameters in the Helm chart for the spark-kubernetes-operator. ### Why are the changes needed? Previously, these values were either using Kubernetes defaults or not configured at all. This change makes them explicitly configurable via Helm values, giving operators more control over pod lifecycle management in different cluster environments (small clusters vs large production clusters). ### Does this PR introduce _any_ user-facing change? Yes. Users can now configure these probe settings in their `values.yaml` ### How was this patch tested? E2E coverage for default value, and local dry-run for value overrides ### Was this patch authored or co-authored using generative AI tooling? No
Contributor
Author
|
cc @peter-toth for review - thanks a lot in advance! |
peter-toth
approved these changes
Nov 13, 2025
Contributor
peter-toth
left a comment
peter-toth
left a comment
There was a problem hiding this comment.
Thank you @jiangzho , it is always better to have more control over these values.
Could you please check the PR description though? The link seems to be broken.
Contributor
Author
|
Thanks for the catch! Seems GitHub interprates that as a JIRA automatically. Updated the description. |
Contributor
|
Thank you @jiangzho. Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a configurable
startupProbeand enhances the existinglivenessProbeandreadinessProbewith additional configurable parameters in the Helm chart for thespark-kubernetes-operator.Why are the changes needed?
Previously, these values were either using Kubernetes defaults or not configured at all. This change makes them explicitly configurable via Helm values, giving operators more control over pod lifecycle management in different cluster environments (small clusters vs large production clusters).
Does this PR introduce any user-facing change?
Yes. Users can now configure these probe settings in their
values.yaml.How was this patch tested?
E2E coverage for default value, and local dry-run for value overrides.
Was this patch authored or co-authored using generative AI tooling?
No.