[SPARK-53786][SQL] Default value should not conflict with special column name

Author: szehon-ho

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala

@@ -175,6 +175,14 @@ trait ColumnResolutionHelper extends Logging with DataTypeErrorsBase {
             u.copy(child = newChild)
           }
 
+        case d @ DefaultValueExpression(u: UnresolvedAttribute, _, _) =>
+          d.copy(child = LiteralFunctionResolution.resolve(u.nameParts)
+            .map {
+              case Alias(child, _) if !isTopLevel => child
+              case other => other
+            }
+            .getOrElse(u))
+
         case _ => e.mapChildren(innerResolve(_, isTopLevel = false))
       }
       resolved.copyTagsFrom(e)

sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala

@@ -3870,6 +3870,19 @@ class DataSourceV2SQLSuiteV1Filter
     }
   }
 
+  test("test default value conflicting with special column name") {
+    withSQLConf(SQLConf.DEFAULT_COLUMN_ALLOWED_PROVIDERS.key -> s"$v2Format, ") {
+      val t = "testcat.ns.t"
+      withTable("t") {
+        sql(s"""CREATE table $t (
+          c1 STRING,
+          c2 TIMESTAMP,
+          c3 BOOLEAN DEFAULT FALSE,
+          current_timestamp TIMESTAMP DEFAULT CURRENT_TIMESTAMP)""")
+      }
+    }
+  }
+
   private def testNotSupportedV2Command(
       sqlCommand: String,
       sqlParams: String,