[SPARK-53795][CONNECT] Remove unused parameters in LiteralValueProtoConverter

Author: heyihong

sql/connect/common/src/main/scala/org/apache/spark/sql/connect/common/LiteralValueProtoConverter.scala

@@ -128,7 +128,7 @@ object LiteralValueProtoConverter {
       options: ToLiteralProtoOptions): proto.Expression.Literal.Builder = {
     val builder = proto.Expression.Literal.newBuilder()
 
-    def arrayBuilder(scalaValue: Any, elementType: DataType, containsNull: Boolean) = {
+    def arrayBuilder(scalaValue: Any, elementType: DataType) = {
       val ab = builder.getArrayBuilder
       scalaValue match {
         case a: Array[_] =>
@@ -148,11 +148,7 @@ object LiteralValueProtoConverter {
       ab
     }
 
-    def mapBuilder(
-        scalaValue: Any,
-        keyType: DataType,
-        valueType: DataType,
-        valueContainsNull: Boolean) = {
+    def mapBuilder(scalaValue: Any, keyType: DataType, valueType: DataType) = {
       val mb = builder.getMapBuilder
       scalaValue match {
         case map: scala.collection.Map[_, _] =>
@@ -214,10 +210,10 @@ object LiteralValueProtoConverter {
         toLiteralProtoBuilderInternal(v.unsafeArray, dataType, options)
       case (v: Array[Byte], ArrayType(_, _)) =>
         toLiteralProtoBuilderInternal(v, options)
-      case (v, ArrayType(elementType, containsNull)) =>
-        builder.setArray(arrayBuilder(v, elementType, containsNull))
-      case (v, MapType(keyType, valueType, valueContainsNull)) =>
-        builder.setMap(mapBuilder(v, keyType, valueType, valueContainsNull))
+      case (v, ArrayType(elementType, _)) =>
+        builder.setArray(arrayBuilder(v, elementType))
+      case (v, MapType(keyType, valueType, _)) =>
+        builder.setMap(mapBuilder(v, keyType, valueType))
       case (v, structType: StructType) =>
         builder.setStruct(structBuilder(v, structType))
       case (v: LocalTime, timeType: TimeType) =>

sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala

@@ -982,6 +982,13 @@ class ColumnExpressionSuite extends QueryTest with SharedSparkSession {
     assert(lit(null).expr == Literal(null, NullType))
   }
 
+  test("BigDecimal") {
+    val result = spark.sql("select 1").select(typedlit((BigDecimal(8997620, 5), 1))).collect()
+    // scalastyle:off println
+    println(result)
+    // scalastyle:on println
+  }
+
   test("typedLit") {
     assert(typedLit($"foo") == $"foo")
     assert(typedLit($"foo") == $"foo")