Skip to content

Commit cc2ecef

Browse files
heyihongcloud-fan
authored andcommitted
[SPARK-55320][SQL][CONNECT] Use raise_error instead of divide by zero in Observation tests
### What changes were proposed in this pull request? Use raise_error instead of divide by zero in Observation tests ### Why are the changes needed? The tests fail when ANSI mode is disabled. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `SPARK_ANSI_SQL_MODE="false" build/sbt "sql/testOnly *DatasetSuite -- -z SPARK-55150"` `SPARK_ANSI_SQL_MODE="false" build/sbt "connect-client-jvm/testOnly *ClientE2ETestSuite -- -z SPARK-55150"` ### Was this patch authored or co-authored using generative AI tooling? Yes Closes #54099 from heyihong/SPARK-55320. Authored-by: Yihong He <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
1 parent 3f5fd65 commit cc2ecef

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/ClientE2ETestSuite.scala

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1620,7 +1620,10 @@ class ClientE2ETestSuite
16201620
val observation = Observation("test_observation")
16211621
val observed_df = spark
16221622
.range(10)
1623-
.observe(observation, sum("id").as("sum_id"), (sum("id") / lit(0)).as("sum_id_div_by_zero"))
1623+
.observe(
1624+
observation,
1625+
sum("id").as("sum_id"),
1626+
raise_error(lit("test error")).as("raise_error"))
16241627

16251628
observed_df.collect()
16261629

sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1164,7 +1164,7 @@ class DatasetSuite extends QueryTest
11641164
val observed_df = spark.range(10).observe(
11651165
observation,
11661166
sum($"id").as("sum_id"),
1167-
(sum($"id") / lit(0)).as("sum_id_div_by_zero")
1167+
raise_error(lit("test error")).as("raise_error")
11681168
)
11691169

11701170
observed_df.collect()
@@ -1173,7 +1173,7 @@ class DatasetSuite extends QueryTest
11731173
observation.get
11741174
}
11751175

1176-
assert(exception.getCause.getMessage.contains("DIVIDE_BY_ZERO"))
1176+
assert(exception.getCause.getMessage.contains("test error"))
11771177
}
11781178

11791179
test("sample with replacement") {

0 commit comments

Comments
 (0)