Skip to content

Commit eaed471

Browse files
yaooqinnLuciferYang
authored andcommitted
[MINOR][BUILD] Remove undefined -Pscala-2.13 profile from dev scripts
### What changes were proposed in this pull request? This PR removes the `-Pscala-2.13` profile specification from two dev scripts: - `dev/lint-scala` - `dev/scalafmt` ### Why are the changes needed? The `-Pscala-2.13` profile is not defined in the project's Maven configuration, making these profile references unnecessary and potentially confusing. The default Scala version configured in `pom.xml` will be used instead, simplifying the build process. ### Changes Made **dev/lint-scala:** - Removed `-Pscala-2.13 \` line from the scalafmt validation command **dev/scalafmt:** - Removed the `VERSION` parameter logic - Removed `-Pscala-$VERSION` from the Maven command ### Does this PR introduce any user-facing change? No. This is an internal build script simplification that doesn't affect end users. ### How was this patch tested? The changes maintain existing functionality by relying on the default Scala version configured in the project's Maven POM files rather than explicitly specifying an undefined profile. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53655 from yaooqinn/remove-scala-2.13-profile-from-dev-scripts. Authored-by: Kent Yao <[email protected]> Signed-off-by: yangjie01 <[email protected]>
1 parent 6695a69 commit eaed471

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

dev/lint-scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ set -e
2626
set +e
2727
# For Spark Connect, we actively enforce scalafmt and check that the produced diff is empty.
2828
ERRORS=$(./build/mvn \
29-
-Pscala-2.13 \
3029
scalafmt:format \
3130
-Dscalafmt.skip=false \
3231
-Dscalafmt.validateOnly=true \

dev/scalafmt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,5 @@
1717
# limitations under the License.
1818
#
1919

20-
VERSION="${@:-2.13}"
21-
./build/mvn -Pscala-$VERSION scalafmt:format -Dscalafmt.skip=false -Dscalafmt.validateOnly=false
20+
./build/mvn scalafmt:format -Dscalafmt.skip=false -Dscalafmt.validateOnly=false
2221

0 commit comments

Comments
 (0)