Skip to content

Commit f84141d

Browse files
committed
[SPARK-53795][CONNECT] Remove unused parameters in LiteralValueProtoConverter
1 parent 984e16b commit f84141d

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

sql/connect/common/src/main/scala/org/apache/spark/sql/connect/common/LiteralValueProtoConverter.scala

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ object LiteralValueProtoConverter {
128128
options: ToLiteralProtoOptions): proto.Expression.Literal.Builder = {
129129
val builder = proto.Expression.Literal.newBuilder()
130130

131-
def arrayBuilder(scalaValue: Any, elementType: DataType, containsNull: Boolean) = {
131+
def arrayBuilder(scalaValue: Any, elementType: DataType) = {
132132
val ab = builder.getArrayBuilder
133133
scalaValue match {
134134
case a: Array[_] =>
@@ -148,11 +148,7 @@ object LiteralValueProtoConverter {
148148
ab
149149
}
150150

151-
def mapBuilder(
152-
scalaValue: Any,
153-
keyType: DataType,
154-
valueType: DataType,
155-
valueContainsNull: Boolean) = {
151+
def mapBuilder(scalaValue: Any, keyType: DataType, valueType: DataType) = {
156152
val mb = builder.getMapBuilder
157153
scalaValue match {
158154
case map: scala.collection.Map[_, _] =>
@@ -214,10 +210,10 @@ object LiteralValueProtoConverter {
214210
toLiteralProtoBuilderInternal(v.unsafeArray, dataType, options)
215211
case (v: Array[Byte], ArrayType(_, _)) =>
216212
toLiteralProtoBuilderInternal(v, options)
217-
case (v, ArrayType(elementType, containsNull)) =>
218-
builder.setArray(arrayBuilder(v, elementType, containsNull))
219-
case (v, MapType(keyType, valueType, valueContainsNull)) =>
220-
builder.setMap(mapBuilder(v, keyType, valueType, valueContainsNull))
213+
case (v, ArrayType(elementType, _)) =>
214+
builder.setArray(arrayBuilder(v, elementType))
215+
case (v, MapType(keyType, valueType, _)) =>
216+
builder.setMap(mapBuilder(v, keyType, valueType))
221217
case (v, structType: StructType) =>
222218
builder.setStruct(structBuilder(v, structType))
223219
case (v: LocalTime, timeType: TimeType) =>

0 commit comments

Comments
 (0)