[SPARK-53805][SQL] Push Variant into DSv2 scan #52522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @peter-toth , too. |
singhpk234
reviewed
Oct 7, 2025
| hadoopFsRelation@HadoopFsRelation(_, _, _, _, _: ParquetFileFormat, _), _)) => | ||
| rewritePlan(p, projectList, filters, relation, hadoopFsRelation) | ||
| case p@PhysicalOperation(projectList, filters, relation: DataSourceV2Relation) => | ||
| rewriteV2RelationPlan(p, projectList, filters, relation.output, relation) |
There was a problem hiding this comment.
if we are sending the relation already do we need to send the relation.output seperately ?
There was a problem hiding this comment.
I overlooked this. Removed.
| SchemaPruning, | ||
| GroupBasedRowLevelOperationScanPlanning, | ||
| V1Writes, | ||
| PushVariantIntoScan, |
There was a problem hiding this comment.
now PushVariantIntoScan runs before the PruneFileSourcePartition, which i think was for v1 sources, does this matter or if i were to ask did we just like add in later, just because it was a new rule ?
There was a problem hiding this comment.
I don't think variant columns will ever be used in the partition schema. Schema transformations by PushVariantIntoScan shouldn't affect partition pruning in v1 sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Push Variant into DSv2 scan
Why are the changes needed?
with the change, DSV2 scan only needs to fetch the necessary shredded columns required by the plan
Does this PR introduce any user-facing change?
No
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
No