[SPARK-45414][SQL][TESTS] Add regression tests for XML mixed type serialization#53857
Open
jdavidroberts wants to merge 4 commits intoapache:masterfrom
Open
[SPARK-45414][SQL][TESTS] Add regression tests for XML mixed type serialization#53857jdavidroberts wants to merge 4 commits intoapache:masterfrom
jdavidroberts wants to merge 4 commits intoapache:masterfrom
Conversation
JIRA Issue Information=== Bug SPARK-45414 === This comment was automatically generated by GitHub Actions |
Author
|
Hi @sandip-db @cloud-fan @dongjoon-hyun, Would appreciate a review when you have time. This PR adds two regression tests for SPARK-45414 to ensure the XML string tag content placement bug doesn't reappear. The bug was originally reported in the external spark-xml library and was fixed during integration into Spark core. These tests verify that:
The tests are straightforward roundtrip write/read verification with clear assertions. All tests pass locally and CI is green. Thank you! |
sandip-db
reviewed
Feb 9, 2026
...est/scala/org/apache/spark/sql/execution/datasources/xml/parsers/StaxXmlGeneratorSuite.scala
Outdated
Show resolved
Hide resolved
...est/scala/org/apache/spark/sql/execution/datasources/xml/parsers/StaxXmlGeneratorSuite.scala
Outdated
Show resolved
Hide resolved
sandip-db
approved these changes
Feb 16, 2026
Contributor
|
LGTM if CI is green, can you do a rebase? |
HyukjinKwon
approved these changes
Feb 19, 2026
…ialization This adds two regression tests for SPARK-45414 to prevent reintroduction of the bug where string tag content was misplaced when writing XML with mixed column types (structs, arrays, and strings). Tests verify: - String columns between and after nested types write correctly - Attributes mixed with string elements serialize properly Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Sandip Agarwala <131817656+sandip-db@users.noreply.github.com>
jdavidroberts
force-pushed
the
spark-45414-xml-tests
branch
2 times, most recently
from
4e8f342 to
4463e00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two regression tests for SPARK-45414 to prevent reintroduction of the bug where string tag content was misplaced when writing XML with mixed column types (structs, arrays, and strings).
Tests verify:
What changes were proposed in this pull request?
Add two regression tests for SPARK-45414 to prevent reintroduction of the bug where string tag content could be misplaced when writing XML with mixed column types.
Why are the changes needed?
SPARK-45414 reported a bug in the spark-xml library where string content was misplaced when writing structs with mixed types. While this bug was fixed during spark-xml integration into Spark core, there were no tests ensuring this specific scenario remains correct. These tests provide coverage for the bug scenario.
Does this PR introduce any user-facing change?
No, this only adds test coverage.
How was this patch tested?
The new tests were run successfully:
Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with Claude Sonnet 4.5.
Generated-by: Claude Sonnet 4.5