[SPARK-55619][SQL] Fix custom metrics in case of coalesced partitions#54396
Closed
peter-toth wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-55619][SQL] Fix custom metrics in case of coalesced partitions#54396peter-toth wants to merge 1 commit intoapache:masterfrom
peter-toth wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
This PR was extracted from #54330 after discussion in #54330 (comment). |
Member
|
Since this includes the revert of SPARK-52809, I'll leave this to @viirya . |
Member
|
Proposed another approach without ThreadLocal: #54399. I added @peter-toth as co-author. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds reverts SPARK-52809 / #51503 and offers a new way to track most recently created reader and do a final metrics update in a task completion listener. The changes are required as
DataSourceRDD.compute()can be called multiple times in thead/task when theDataSourceRDDgets coalesced. Please find an example in the new test.Why are the changes needed?
To calculate custom metrics correctly.
Does this PR introduce any user-facing change?
It fixes metrics calculation.
How was this patch tested?
New UT is added.
Was this patch authored or co-authored using generative AI tooling?
No.