[SPARK-55502][PYTHON] Unify UDF and UDTF Arrow conversion error handling#54398
Open
Yicong-Huang wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-55502][PYTHON] Unify UDF and UDTF Arrow conversion error handling#54398Yicong-Huang wants to merge 2 commits intoapache:masterfrom
Yicong-Huang wants to merge 2 commits intoapache:masterfrom
Conversation
Yicong-Huang
force-pushed
the
SPARK-55502/refactor/eliminate-is-udtf-flag
branch
from
4b2718e to
e250ebf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the
is_udtfparameter fromPandasToArrowConversion.convert()and unify the error handling logic for both UDF and UDTF conversions.Key changes:
is_udtf: boolparameter from conversion methodsArrowExceptioncatchingUDTF_ARROW_TYPE_CAST_ERRORwith genericPySparkTypeError/PySparkValueErrorWhy are the changes needed?
The
is_udtfflag was used to differentiate error handling between UDF and UDTF, but this created unnecessary complexity and inconsistent error messages. Unifying the logic provides:Does this PR introduce any user-facing change?
Yes, user would see a different error message (error messages change from UDTF-specific to generic), but functionality remains the same.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.