Skip to content

Commit 5c2c1ff

Browse files
Update checks for SERF 1.4.0 to check for SERF 1.5.0. There will never
be a SERF 1.4.0 release and these APIs are officially available from 1.5.0 so it should not be a functional change but make things consistent. * subversion/libsvn_ra_serf/serf.c, subversion/libsvn_ra_serf/update.c, subversion/libsvn_ra_serf/update.c: Above git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1931176 13f79535-47bb-0310-9956-ffa450edef68
1 parent 80c5d5f commit 5c2c1ff

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

subversion/libsvn_ra_serf/serf.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ load_config(svn_ra_serf__session_t *session,
166166
apr_port_t proxy_port;
167167
svn_tristate_t chunked_requests;
168168
#ifdef SVN__SERF_EXPERIMENTAL
169-
#if SERF_VERSION_AT_LEAST(1, 4, 0) && !defined(SVN_SERF_NO_LOGGING)
169+
#if SERF_VERSION_AT_LEAST(1, 5, 0) && !defined(SVN_SERF_NO_LOGGING)
170170
apr_int64_t log_components;
171171
apr_int64_t log_level;
172172
#endif
@@ -255,7 +255,7 @@ load_config(svn_ra_serf__session_t *session,
255255
"auto", svn_tristate_unknown));
256256

257257
#ifdef SVN__SERF_EXPERIMENTAL
258-
#if SERF_VERSION_AT_LEAST(1, 4, 0) && !defined(SVN_SERF_NO_LOGGING)
258+
#if SERF_VERSION_AT_LEAST(1, 5, 0) && !defined(SVN_SERF_NO_LOGGING)
259259
SVN_ERR(svn_config_get_int64(config, &log_components,
260260
SVN_CONFIG_SECTION_GLOBAL,
261261
SVN_CONFIG_OPTION_SERF_LOG_COMPONENTS,
@@ -324,7 +324,7 @@ load_config(svn_ra_serf__session_t *session,
324324
"auto", chunked_requests));
325325

326326
#ifdef SVN__SERF_EXPERIMENTAL
327-
#if SERF_VERSION_AT_LEAST(1, 4, 0) && !defined(SVN_SERF_NO_LOGGING)
327+
#if SERF_VERSION_AT_LEAST(1, 5, 0) && !defined(SVN_SERF_NO_LOGGING)
328328
SVN_ERR(svn_config_get_int64(config, &log_components,
329329
server_group,
330330
SVN_CONFIG_OPTION_SERF_LOG_COMPONENTS,
@@ -338,7 +338,7 @@ load_config(svn_ra_serf__session_t *session,
338338
}
339339

340340
#ifdef SVN__SERF_EXPERIMENTAL
341-
#if SERF_VERSION_AT_LEAST(1, 4, 0) && !defined(SVN_SERF_NO_LOGGING)
341+
#if SERF_VERSION_AT_LEAST(1, 5, 0) && !defined(SVN_SERF_NO_LOGGING)
342342
if (log_components != SERF_LOGCOMP_NONE)
343343
{
344344
serf_log_output_t *output;
@@ -599,7 +599,7 @@ svn_ra_serf__open(svn_ra_session_t *session,
599599
600600
Luckily our caller now passes us two pools which handle this case.
601601
*/
602-
#if defined(SVN_DEBUG) && !SERF_VERSION_AT_LEAST(1,4,0)
602+
#if defined(SVN_DEBUG) && !SERF_VERSION_AT_LEAST(1,5,0)
603603
/* Currently ensured by svn_ra_open5().
604604
If failing causes segfault in basic_tests.py 48, "basic auth test" */
605605
SVN_ERR_ASSERT((serf_sess->pool != scratch_pool)

subversion/libsvn_ra_serf/update.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -616,7 +616,7 @@ get_best_connection(report_context_t *ctx)
616616
}
617617
else
618618
{
619-
#if defined(SVN__SERF_EXPERIMENTAL) && SERF_VERSION_AT_LEAST(1, 4, 0)
619+
#if defined(SVN__SERF_EXPERIMENTAL) && SERF_VERSION_AT_LEAST(1, 5, 0)
620620
/* Often one connection is slower than others, e.g. because the server
621621
process/thread has to do more work for the particular set of requests.
622622
In the worst case, when REQUEST_COUNT_TO_RESUME requests are queued

subversion/libsvn_ra_serf/util.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ load_authorities(svn_ra_serf__connection_t *conn, const char *authorities,
482482
}
483483

484484
#ifdef SVN__SERF_EXPERIMENTAL
485-
#if SERF_VERSION_AT_LEAST(1, 4, 0) && defined(SVN__SERF_TEST_HTTP2)
485+
#if SERF_VERSION_AT_LEAST(1, 5, 0) && defined(SVN__SERF_TEST_HTTP2)
486486
/* Implements serf_ssl_protocol_result_cb_t */
487487
static apr_status_t
488488
conn_negotiate_protocol(void *data,
@@ -561,7 +561,7 @@ conn_setup(apr_socket_t *sock,
561561
conn->session->pool));
562562
}
563563
#ifdef SVN__SERF_EXPERIMENTAL
564-
#if SERF_VERSION_AT_LEAST(1, 4, 0) && defined(SVN__SERF_TEST_HTTP2)
564+
#if SERF_VERSION_AT_LEAST(1, 5, 0) && defined(SVN__SERF_TEST_HTTP2)
565565
if (APR_SUCCESS ==
566566
serf_ssl_negotiate_protocol(conn->ssl_context, "h2,http/1.1",
567567
conn_negotiate_protocol, conn))
@@ -2277,7 +2277,7 @@ svn_ra_serf__default_readline(serf_bucket_t *bucket, int acceptable,
22772277
int *found,
22782278
const char **data, apr_size_t *len)
22792279
{
2280-
#if defined(SVN__SERF_EXPERIMENTAL) && SERF_VERSION_AT_LEAST(1, 4, 0)
2280+
#if defined(SVN__SERF_EXPERIMENTAL) && SERF_VERSION_AT_LEAST(1, 5, 0)
22812281
return serf_default_readline(bucket, acceptable, found, data, len);
22822282
#else
22832283
return bucket_limited_readline(bucket, acceptable, SERF_READ_ALL_AVAIL,

0 commit comments

Comments
 (0)