Merge r1924100 from trunk:

 * r1924100
   Deprecate and disable the SVN_UNALIGNED_ACCESS_IS_OK macro.
   Justification:
     Prevent future problems on newer compilers on higher optimization
     settings.
   Votes:
     +1: dsahlberg, brane, jamessan


git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/1.14.x@1924794 13f79535-47bb-0310-9956-ffa450edef68

Author: svn-role

STATUS

@@ -36,14 +36,6 @@ Veto-blocked changes:
 Approved changes:
 =================
 
- * r1924100
-   Deprecate and disable the SVN_UNALIGNED_ACCESS_IS_OK macro.
-   Justification:
-     Prevent future problems on newer compilers on higher optimization
-     settings.
-   Votes:
-     +1: dsahlberg, brane, jamessan
-
 * r1924143
   Remove optimized unaligned-access code paths.
   Justification:
@@ -58,4 +50,3 @@ Approved changes:
     Allow swig-rb with x64-mswin64 and gcc 15
   Votes:
     +1: jun66j5, jamessan
-

notes/knobs

@@ -38,7 +38,7 @@ SUFFIX_LINES_TO_KEEP
 SVN_FS_FS_DEFAULT_MAX_FILES_PER_DIR
 SVN_FS_FS_MAX_LINEAR_DELTIFICATION
 SVN_FS_FS_MAX_DELTIFICATION_WALK
-SVN_UNALIGNED_ACCESS_IS_OK
+SVN_UNALIGNED_ACCESS_IS_OK (deprecated)
 
 2.2 Features
 
@@ -164,12 +164,14 @@ SVN_I_LIKE_LATENCY_SO_IGNORE_HTTPV2
 
 3.8 SVN_UNALIGNED_ACCESS_IS_OK
 
+  DEPRECATED, unused. The rest of this entry is historical.
+
   Scope:     (global)
   Purpose:   enable data accesss optimizations.
              If your target CPU supports unaligned memory access without
              significant performance penalties, you should enable this
              optimization as it allows for processing 4 or 8 bytes at
-             once instead of just one byte at a time. 
+             once instead of just one byte at a time.
   Range:     0 1
   Default:   platform dependant (see svn_types.h)
   Suggested: 0

subversion/include/svn_types.h

@@ -124,16 +124,12 @@ extern "C" {
  * if unaligned access is supported for integers.
  *
  * @since New in 1.7.
+ * @deprecated Provided for backward compatibility with the 1.14 API.
  */
-#ifndef SVN_UNALIGNED_ACCESS_IS_OK
-# if defined(_M_IX86) || defined(i386) \
-     || defined(_M_X64) || defined(__x86_64) \
-     || defined(__powerpc__) || defined(__ppc__)
-#  define SVN_UNALIGNED_ACCESS_IS_OK 1
-# else
-#  define SVN_UNALIGNED_ACCESS_IS_OK 0
-# endif
+#ifdef SVN_UNALIGNED_ACCESS_IS_OK
+#  undef SVN_UNALIGNED_ACCESS_IS_OK
 #endif
+#define SVN_UNALIGNED_ACCESS_IS_OK 0