fix: correct styled modal prop usage for resizable behavior

Mayankaggarwal8055 · Mayankaggarwal8055 · commit 419251589326 · 2026-03-19T21:04:36.000+05:30
diff --git a/superset-frontend/src/components/Modal/StandardModal.tsx b/superset-frontend/src/components/Modal/StandardModal.tsx
@@ -50,9 +50,9 @@ export const MODAL_STANDARD_WIDTH = 500;
 export const MODAL_MEDIUM_WIDTH = 600;
 export const MODAL_LARGE_WIDTH = 900;
 
-const StyledModal = styled(Modal)`
+const StyledModal = styled(Modal)<{ $resizable?: boolean }>`
   .ant-modal-body {
-    max-height: 80vh;
+    max-height: ${({ $resizable }) => ($resizable ? 'none' : '80vh')};
     height: auto;
     overflow-y: auto;
   }
@@ -144,6 +144,7 @@ export function StandardModal({
           title
         )
       }
+      $resizable={resizable}
       resizable={resizable}
       draggable={draggable}
     >

Original file line number	Diff line number	Diff line change
`@@ -50,9 +50,9 @@ export const MODAL_STANDARD_WIDTH = 500;`
`50`	`50`	`export const MODAL_MEDIUM_WIDTH = 600;`
`51`	`51`	`export const MODAL_LARGE_WIDTH = 900;`
`52`	`52`
`53`		-const StyledModal = styled(Modal)`
	`53`	+const StyledModal = styled(Modal)<{ $resizable?: boolean }>`
`54`	`54`	`.ant-modal-body {`
`55`		`- max-height: 80vh;`
	`55`	`+ max-height: ${({ $resizable }) => ($resizable ? 'none' : '80vh')};`
`56`	`56`	`height: auto;`
`57`	`57`	`overflow-y: auto;`
`58`	`58`	`}`
`@@ -144,6 +144,7 @@ export function StandardModal({`
`144`	`144`	`title`
`145`	`145`	`)`
`146`	`146`	`}`
	`147`	`+ $resizable={resizable}`
`147`	`148`	`resizable={resizable}`
`148`	`149`	`draggable={draggable}`
`149`	`150`	`>`