Refactor crossFilters logic for chartsInScope

Author: Mayankaggarwal8055

superset-frontend/src/dashboard/util/crossFilters.ts

@@ -98,18 +98,17 @@ export const getCrossFiltersConfiguration = (
           },
         };
       }
-        const scope = chartConfiguration[chartId].crossFilters.scope;
-
-        const effectiveScope: NativeFilterScope = isCrossFilterScopeGlobal(scope)
-          ? globalChartConfiguration.scope
-          : scope;
-
-        chartConfiguration[chartId].crossFilters.chartsInScope =
-          getChartIdsInFilterScope(
-            effectiveScope,
-            Object.values(charts).map(chart => chart.id),
-            chartLayoutItems,
-          ).filter(id => id !== Number(chartId));
+      chartConfiguration[chartId].crossFilters.chartsInScope =
+        isCrossFilterScopeGlobal(chartConfiguration[chartId].crossFilters.scope)
+          ? globalChartConfiguration.chartsInScope.filter(
+              id => id !== Number(chartId),
+            )
+          : getChartIdsInFilterScope(
+              chartConfiguration[chartId].crossFilters
+                .scope as NativeFilterScope,
+              Object.values(charts).map(chart => chart.id),
+              chartLayoutItems,
+            ).filter(id => id !== Number(chartId));
     }
   });