fix(dashboard): enable cross-filtering across tabs

Author: Mayankaggarwal8055

superset-frontend/src/dashboard/util/crossFilters.ts

@@ -98,17 +98,10 @@ export const getCrossFiltersConfiguration = (
           },
         };
       }
-      chartConfiguration[chartId].crossFilters.chartsInScope =
-        isCrossFilterScopeGlobal(chartConfiguration[chartId].crossFilters.scope)
-          ? globalChartConfiguration.chartsInScope.filter(
-              id => id !== Number(chartId),
-            )
-          : getChartIdsInFilterScope(
-              chartConfiguration[chartId].crossFilters
-                .scope as NativeFilterScope,
-              Object.values(charts).map(chart => chart.id),
-              chartLayoutItems,
-            );
+        chartConfiguration[chartId].crossFilters.chartsInScope =
+          Object.values(charts)
+            .map(chart => chart.id)
+            .filter(id => id !== Number(chartId));
     }
   });
 

superset-frontend/src/dashboard/util/getRelatedCharts.ts

@@ -55,31 +55,10 @@ function getRelatedChartsForCrossFilter(
   slices: Record<string, Slice>,
   scope: number[],
 ): number[] {
-  const sourceSlice = slices[filterKey];
-
-  if (!sourceSlice) return [];
-
-  const fullScope = [
-    ...scope.filter(s => String(s) !== filterKey),
-    Number(filterKey),
-  ];
-  const scopeSet = new Set(scope);
-
-  return Object.values(slices).reduce((result: number[], slice) => {
-    if (slice.slice_id === Number(filterKey)) {
-      return result;
-    }
-    // Check if it's in the global scope
-    if (isGlobalScope(fullScope, slices)) {
-      result.push(slice.slice_id);
-      return result;
-    }
-    // Check if it's hand-picked in scope
-    if (scopeSet.has(slice.slice_id)) {
-      result.push(slice.slice_id);
-    }
-    return result;
-  }, []);
+  // Always return all charts except source chart
+  return Object.values(slices)
+    .map(slice => slice.slice_id)
+    .filter(id => id !== Number(filterKey));
 }
 
 export function getRelatedCharts(