feat: add custom thresholds and colors to CountryMap plugin #36732

Facyla · 2025-12-18T10:33:09Z

User description

SUMMARY

Add a JSON-based customization block that allows to override linearColorScheme colors and thresholds with custom thresholds and colors.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Paste a sample customization in "Custom Color Scale": the linearScheme is overrided, resulting in the customized Color Scheme to apply.
[ { "percent": 0, "color": "white" }, { "percent": 0.01, "color": "#FF0000AA" }, { "percent": 20, "color": "#FA0" }, { "percent": 50, "color": "#FF0" }, { "percent": 65, "color": "#9F0" }, { "percent": 99.99, "color": "#000A" }, { "percent": 100, "color": "black" } ]
The inline help provides a sample configuration that can also be copied/pasted (with some cleaning and lines returns).
Edit sample values to adjust to the map needs: the changes appear immediately on map
- update thresholds with values in percentage; decimal values allowed (eg. 0.001): the color will be applied from that lower limit up to the next one
- adjust colors, using any valid CSS color, including named colors (red, green, etc.), rgb and hex codes, with or without transparency. A color selector helps visually choosing the color value
- add or remove thresholds to fit your needs
The provided configuration requires a full valid JSON, including brackets, commas except for the last line, quoted keys and quoted values for color codes.

ADDITIONAL INFORMATION

Has associated issue: Implement custom formatting similar to Table Chart into Country Map plugin #34427
Required feature flags:
Changes UI: add a new control
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

CodeAnt-AI Description

Allow custom percent-based color scales for CountryMap and add a color picker

What Changed

Users can paste a JSON list of percent/color entries in a new "Custom Color Scale (by %)" textarea to override the map's linear color scheme; the map immediately uses those thresholds and colors.
A new color picker control provides an easy way to pick a color and copy its HEX into the custom scale.
The chart now tolerates malformed or missing inputs: invalid JSON, invalid colors, or non-numeric metrics fall back to safe defaults and won't break rendering; identical metric values map to a central color.
If no valid custom scale is provided, the existing linear color scheme is used as before.

Impact

✅ Clearer thematic maps with user-defined thresholds
✅ Immediate visual feedback when editing color scales
✅ Fewer rendering errors from invalid custom color inputs

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

…lity issue

codeant-ai-for-open-source · 2025-12-18T10:33:15Z

CodeAnt AI is reviewing your PR.

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

codeant-ai-for-open-source · 2025-12-18T10:36:12Z

Nitpicks 🔍

🔒 No security issues identified
⚡ Recommended areas for review d3 API compatibility The new code uses `d3.scale.linear()` and `d3.geo.path()`. If the project uses a different major d3 version (v4+), these APIs are deprecated/renamed (`d3.scaleLinear`, `d3.geoPath`). Verify d3 version compatibility to avoid runtime errors. Empty color handling The sample configuration in the PR description allows an empty string for a color (e.g., `""`) to denote transparency, but `normalizeColorKeyword` currently treats empty strings as invalid and falls back to `#000000`. This will map empty colors to black rather than transparent/none which is likely not intended. DOM-only API use `normalizeColorKeyword` calls `new Option()` to validate named CSS colors. This relies on a browser DOM being present; tests or server-side execution without a DOM will throw. Consider guarding or using a safer check to avoid runtime errors in non-browser environments. Prop name mismatch The component uses `customColorScale` from props but PropTypes defines `customColorRules`. This mismatch means prop type validation won't match the real prop and consumers may pass the wrong prop name. Ensure the prop name is consistent in PropTypes and in the function signature.

superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js

superset-frontend/plugins/legacy-plugin-chart-country-map/src/transformProps.js

codeant-ai-for-open-source · 2025-12-18T10:38:13Z

CodeAnt AI finished reviewing your PR.

…ehaviour

bito-code-review

Code Review Agent Run #d66de9

Actionable Suggestions - 2

superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js - 2
- Prop name mismatch in PropTypes · Line 44-44
- Incorrect Color Scale Implementation · Line 159-169

Additional Suggestions - 3

superset-frontend/plugins/legacy-plugin-chart-country-map/src/transformProps.js - 1
- Convert JS to TS for type safety · Line 27-27
  
  This JavaScript file should be converted to TypeScript to align with codebase standards that prohibit new JavaScript files and require type safety. The added customColorScale parsing logic is correct but would benefit from TypeScript types for better maintainability.
superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js - 2
- Outdated CSS color regexes · Line 57-60
  
  The regexes for CSS color functions only match comma-separated syntax (e.g., rgb(255, 0, 0)), but modern CSS supports space-separated syntax (e.g., rgb(255 0 0)). This could cause valid modern color strings to be rejected as invalid, falling back to '#000000'.
- Unused function (dead code) · Line 78-89
  
  The rgbaToHex function is defined but never called in the codebase. While it might be intended for future color handling, removing it now keeps the code clean and avoids maintenance overhead.

Review Details

Files reviewed - 3 · Commit Range: ca2e1b8..30fcc46
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/controlPanel.ts
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/transformProps.js
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js

…ymap-plugin

codeant-ai-for-open-source · 2025-12-24T11:46:09Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

bito-code-review · 2025-12-24T12:48:20Z

Code Review Agent Run #3475b2

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 30fcc46..ade8c16
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/controlPanel.ts
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/transformProps.js
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

Facyla · 2025-12-24T13:49:45Z

Hi,
PR has been updated to sync PR with the 6.0.0 release: no conflict.

rusackas · 2026-01-03T07:27:33Z

Running CI!

Copilot

Pull request overview

This pull request adds customizable color scales to the CountryMap plugin, allowing users to define custom color thresholds based on percentage values. The feature enables more flexible thematic map visualizations by letting users override the default linear color scheme with JSON-configured breakpoints and colors.

Key Changes:

Added JSON-based custom color scale configuration that accepts percent/color pairs for precise threshold control
Introduced a color picker control to help users select and identify HEX color codes
Implemented robust error handling for invalid JSON, malformed color values, and edge cases in metric data

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File	Description
`transformProps.js`	Parses and validates the custom color scale JSON configuration, passing sanitized data to the chart component
`controlPanel.ts`	Adds two new controls: a TextArea for JSON color scale input and a ColorPicker for color selection assistance
`CountryMap.js`	Implements core logic for custom color scale processing, including color validation, data normalization, and fallback handling for both custom and linear color schemes

superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js

superset-frontend/plugins/legacy-plugin-chart-country-map/src/controlPanel.ts

superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js

…ugin

codeant-ai-for-open-source · 2026-01-07T13:43:21Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

Facyla · 2026-01-07T13:45:05Z

Hi,
PR updated:

Synced with master as of 2026-01-07 morning commit cedc35e
Fixed pre-commit issue (a redundant newline)

bito-code-review · 2026-01-07T14:46:18Z

Code Review Agent Run #89823c

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: ade8c16..63c7506
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/controlPanel.ts
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/transformProps.js
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

…CountryMap.js Co-authored-by: Copilot <[email protected]>

…CountryMap.js Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

netlify · 2026-01-28T15:41:14Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`ea4c0fe`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/697a2d5829274100086d87d2
😎 Deploy Preview	https://deploy-preview-36732--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…CountryMap.js Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

netlify · 2026-01-28T15:44:46Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`4daf361`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/697a2d8beccb190008fe0362
😎 Deploy Preview	https://deploy-preview-36732--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…transformProps.js Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

Facyla · 2026-01-28T16:17:50Z

Hi @rusackas and dear reviewers/mainteainers

I'm struggling to keep this PR in sync with master branch and handling AI bot comments that are pretty relevant, but tend to introduce more complexity than it should.
This is the 2nd PR, initial PR became unreadable so i created this one to keep the changes readable/reviewable - as they only are made in a plugin folder, and in very few files.
These AI reviews are interesting and quite powerful, but not easy to handle from an organizational point of view (and a little perturbing because there is non consistence into the recommendations which sometimes complexify things, then protest against that move).

Goal here is not to provide a fancy UI or too much guidance for end-users, but to give more control on chloropleth map rendering for advanced map creators.

I hope these latest changes might help making advance into integrating this into the project :)

Yours

bito-code-review

Code Review Agent Run #32187a

Actionable Suggestions - 1

superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js - 1
- Broken interpolator function · Line 163-165

Review Details

Files reviewed - 3 · Commit Range: 63c7506..3e81051
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/controlPanel.ts
- superset-frontend/plugins/legacy-plugin-chart-country-map/src/transformProps.js
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-01-28T16:54:41Z

superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js

+        .interpolate(function (a, b) {
+          return a;
+        });


Broken interpolator function

The interpolate method must return an interpolator function, not a value. Returning 'a' directly will cause a TypeError when d3 calls it with a parameter t, breaking color scaling for custom color rules.

Code suggestion

Check the AI-generated fix before applying

Suggested change

.interpolate(function (a, b) {

return a;

});

.interpolate(function (a, b) {

return function(t) { return a; };

});

Code Review Run #32187a

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

Yes, avoid them

Facyla added 2 commits December 18, 2025 08:59

Port custom color scale feat to 6.0.0.rc4

ca2e1b8

[min] Remove shading as new hover-popup handles the same text readabi…

30fcc46

…lity issue

Facyla requested review from rusackas and villebro as code owners December 18, 2025 10:33

pull-request-size bot added the size/L label Dec 18, 2025

github-actions bot added the plugins label Dec 18, 2025

codeant-ai-for-open-source bot added the size:L This PR changes 100-499 lines, ignoring generated files label Dec 18, 2025

Facyla mentioned this pull request Dec 18, 2025

feat: add custom colors and thresholds for CountryMap plugin #36103

Closed

9 tasks

codeant-ai-for-open-source bot reviewed Dec 18, 2025

View reviewed changes

[min] Remove default config to avoid breaking change in default map b…

f60e04f

…ehaviour

bito-code-review bot reviewed Dec 18, 2025

View reviewed changes

superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js Outdated Show resolved Hide resolved

superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js Show resolved Hide resolved

Facyla and others added 3 commits December 18, 2025 11:49

[min] Fix prop-name mismatch

05bdeac

[min] Remove unused function

ec116e6

Merge branch 'apache:master' into feat/custom-color-scales-for-countr…

ade8c16

…ymap-plugin

rusackas requested a review from Copilot January 3, 2026 07:27

Copilot started reviewing on behalf of rusackas January 3, 2026 07:28 View session

Copilot AI reviewed Jan 3, 2026

View reviewed changes

Merge branch 'master' into feat/custom-color-scales-for-countrymap-pl…

c44cf98

…ugin

[min] Fix pre-commit linter issue (redundant newline)

63c7506

Update superset-frontend/plugins/legacy-plugin-chart-country-map/src/…

ea4c0fe

…CountryMap.js Co-authored-by: Copilot <[email protected]>

Update superset-frontend/plugins/legacy-plugin-chart-country-map/src/…

4daf361

…CountryMap.js Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

Update superset-frontend/plugins/legacy-plugin-chart-country-map/src/…

059ef9c

…CountryMap.js Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

Facyla and others added 2 commits January 28, 2026 16:45

Update superset-frontend/plugins/legacy-plugin-chart-country-map/src/…

2d240fe

…transformProps.js Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

Fix name mismatch issue apache#36732 (review)

3e81051

bito-code-review bot reviewed Jan 28, 2026

View reviewed changes

feat: add custom thresholds and colors to CountryMap plugin #36732

Are you sure you want to change the base?

feat: add custom thresholds and colors to CountryMap plugin #36732

Conversation

Facyla commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

CodeAnt-AI Description

What Changed

Impact

Checking Your Pull Request

Talking to CodeAnt AI

Example

Preserve Org Learnings with CodeAnt

Example

Retrigger review

Check Your Repository Health

Uh oh!

codeant-ai-for-open-source bot commented Dec 18, 2025

Thanks for using CodeAnt! 🎉

Uh oh!

codeant-ai-for-open-source bot commented Dec 18, 2025

Nitpicks 🔍

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codeant-ai-for-open-source bot commented Dec 18, 2025

Uh oh!

bito-code-review bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Code Review Agent Run #d66de9

Uh oh!

Uh oh!

Uh oh!

codeant-ai-for-open-source bot commented Dec 24, 2025

Thanks for using CodeAnt! 🎉

Uh oh!

bito-code-review bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #3475b2

Uh oh!

Facyla commented Dec 24, 2025

Uh oh!

rusackas commented Jan 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codeant-ai-for-open-source bot commented Jan 7, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

Facyla commented Jan 7, 2026

Uh oh!

bito-code-review bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #89823c

Uh oh!

netlify bot commented Jan 28, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

netlify bot commented Jan 28, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

Facyla commented Dec 18, 2025 •

edited

Loading

bito-code-review bot left a comment •

edited

Loading

bito-code-review bot commented Dec 24, 2025 •

edited

Loading

bito-code-review bot commented Jan 7, 2026 •

edited

Loading

bito-code-review bot left a comment •

edited

Loading