Skip to content

feat(build): skip merging coverage results as Codecov do this automatically#38485

Open
hainenber wants to merge 2 commits intomasterfrom
build/optimize-codecov-coverage-upload
Open

feat(build): skip merging coverage results as Codecov do this automatically#38485
hainenber wants to merge 2 commits intomasterfrom
build/optimize-codecov-coverage-upload

Conversation

@hainenber
Copy link
Contributor

@hainenber hainenber commented Mar 7, 2026

User description

feat(build): skip merging coverage results as Codecov do this automatically

SUMMARY

Chore PR to delegate merging code coverage results from shared tests to CodeCov. No need for nyc to do this anymore.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Code coverage result is still present after this PR takes place.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CodeAnt-AI Description

Skip merging frontend coverage artifacts and upload raw coverage directory to Codecov

What Changed

  • CI no longer runs a step to merge per-shard coverage files; the workflow uploads the collected coverage directory directly to Codecov
  • Removed an unused nyc TypeScript config dev dependency from the frontend package, and trimmed related packaged entries from lockfile
  • Coverage reports remain produced by tests and are still uploaded, but no local merge output is required

Impact

✅ Fewer CI steps for frontend coverage
✅ Shorter frontend CI runs
✅ Fewer coverage merge errors

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

…ically

Signed-off-by: hainenber <dotronghai96@gmail.com>
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Mar 7, 2026

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@hainenber
Copy link
Contributor Author

Coverage result is still successfully uploaded to CodeCov (link)

image

Signed-off-by: hainenber <dotronghai96@gmail.com>
@codeant-ai-for-open-source codeant-ai-for-open-source bot added the size:S This PR changes 10-29 lines, ignoring generated files label Mar 8, 2026
@codeant-ai-for-open-source
Copy link
Contributor

Sequence Diagram

This PR removes the local merging of per-shard frontend coverage results in CI and instead uploads the collected coverage directory directly to Codecov, delegating merging to Codecov and simplifying the workflow.

sequenceDiagram
    participant GH_Actions as GitHub Actions Runner
    participant Artifacts as Coverage Artifacts (workspace/coverage)
    participant Codecov as Codecov Action

    GH_Actions->>Artifacts: Download coverage-artifacts-* into coverage/
    Note right of GH_Actions: Previously: reorganize & npx nyc merge -> merged-output/coverage-summary.json
    GH_Actions->>Codecov: Upload coverage directory (coverage) via codecov-action
    Codecov-->>GH_Actions: Process & merge coverage reports (server-side)
Loading

Generated by CodeAnt AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies:npm github_actions Pull requests that update GitHub Actions code size/S size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant