New statements to investigate GH actions failures

Author: ilgrosso

core/idm/logic/src/main/java/org/apache/syncope/core/logic/ReconciliationLogic.java

@@ -399,6 +399,8 @@ public List<ProvisioningReport> push(
         } catch (JobExecutionException e) {
             LOG.error("Could not perform single push", e);
             sce.getElements().add(e.getMessage());
+
+            ExceptionUtils.getStackTrace(e).lines().forEach(line -> sce.getElements().add(line));
         }
 
         if (!sce.isEmpty()) {

fit/core-reference/src/test/java/org/apache/syncope/fit/AbstractITCase.java

@@ -21,6 +21,7 @@
 import static org.awaitility.Awaitility.await;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.fail;
 
 import com.nimbusds.jose.JWSAlgorithm;
 import com.unboundid.ldap.sdk.AddRequest;
@@ -92,6 +93,7 @@
 import org.apache.syncope.common.lib.to.AuditEventTO;
 import org.apache.syncope.common.lib.to.ClientAppTO;
 import org.apache.syncope.common.lib.to.ConnInstanceTO;
+import org.apache.syncope.common.lib.to.EntityTO;
 import org.apache.syncope.common.lib.to.ExecTO;
 import org.apache.syncope.common.lib.to.GroupTO;
 import org.apache.syncope.common.lib.to.ImplementationTO;
@@ -791,6 +793,17 @@ protected static List<BatchResponseItem> parseBatchResponse(final Response respo
                 (InputStream) response.getEntity(), response.getMediaType(), new BatchResponseItem());
     }
 
+    protected static <E extends EntityTO> E getEntity(final ProvisioningResult<E> result) {
+        List<String> failures = result.getPropagationStatuses().stream().
+                filter(status -> status.getStatus() != ExecStatus.SUCCESS).
+                map(status -> "Propagation to " + status.getResource()
+                + " was not successful: " + status.getFailureReason()).toList();
+        if (!failures.isEmpty()) {
+            fail(String.join("\n", failures));
+        }
+        return result.getEntity();
+    }
+
     private static <T> T execOnLDAP(
             final String bindDn,
             final String bindPassword,

fit/core-reference/src/test/java/org/apache/syncope/fit/core/PullTaskITCase.java

@@ -420,6 +420,9 @@ public void reconcileFromLDAP() {
         ExecTO execution = execSchedTask(TASK_SERVICE, TaskType.PULL, LDAP_PULL_TASK, MAX_WAIT_SECONDS, false);
 
         // 1. verify execution status
+        if (!ExecStatus.SUCCESS.equals(ExecStatus.valueOf(execution.getStatus()))) {
+            fail("LDAP PullTask failed:\n" + execution.getMessage());
+        }
         assertEquals(ExecStatus.SUCCESS, ExecStatus.valueOf(execution.getStatus()));
 
         // SYNCOPE-898
@@ -1269,7 +1272,7 @@ public void issueSYNCOPE313LDAP() throws Exception {
             UserCR userCR = UserITCase.getUniqueSample("[email protected]");
             userCR.setPassword(oldCleanPassword);
             userCR.getResources().add(RESOURCE_NAME_LDAP);
-            user = createUser(userCR).getEntity();
+            user = getEntity(createUser(userCR));
             assertNotNull(user);
             assertFalse(user.getResources().isEmpty());
 
@@ -1278,7 +1281,7 @@ public void issueSYNCOPE313LDAP() throws Exception {
             UserUR userUR = new UserUR();
             userUR.setKey(user.getKey());
             userUR.setPassword(new PasswordPatch.Builder().value(newCleanPassword).build());
-            user = updateUser(userUR).getEntity();
+            user = getEntity(updateUser(userUR));
 
             // 3. Check that the Syncope user now has the changed password
             SyncopeClient.Self self = CLIENT_FACTORY.create(user.getUsername(), newCleanPassword).self();

fit/core-reference/src/test/java/org/apache/syncope/fit/core/PushTaskITCase.java

@@ -126,8 +126,12 @@ public void pushMatchingUnmatchingGroups() {
         assertFalse(GROUP_SERVICE.read("29f96485-729e-4d31-88a1-6fc60e4677f3").
                 getResources().contains(RESOURCE_NAME_LDAP));
 
-        execSchedTask(
+        ExecTO execution = execSchedTask(
                 TASK_SERVICE, TaskType.PUSH, "fd905ba5-9d56-4f51-83e2-859096a67b75", MAX_WAIT_SECONDS, false);
+        if (!ExecStatus.SUCCESS.equals(ExecStatus.valueOf(execution.getStatus()))) {
+            fail("LDAP PushTask failed:\n" + execution.getMessage());
+        }
+        assertEquals(ExecStatus.SUCCESS, ExecStatus.valueOf(execution.getStatus()));
 
         assertNotNull(RESOURCE_SERVICE.readConnObject(
                 RESOURCE_NAME_LDAP, AnyTypeKind.GROUP.name(), "29f96485-729e-4d31-88a1-6fc60e4677f3"));