-
Notifications
You must be signed in to change notification settings - Fork 200
[SYNCOPE-1942] added getString to retrieve the label from localization properties file #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…n properties file
ilgrosso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides what reported above, the same approach should be applied to extPages in the same way
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/BasePage.java
Outdated
Show resolved
Hide resolved
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/BasePage.java
Outdated
Show resolved
Hide resolved
...drepo/console/src/main/resources/org/apache/syncope/client/console/pages/BasePage.properties
Outdated
Show resolved
Hide resolved
|
@massx1 welcome back! |
done |
...n-ui/src/main/java/org/apache/syncope/client/ui/commons/DynamicMenuStringResourceLoader.java
Outdated
Show resolved
Hide resolved
...idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DynamicMenuRegister.java
Outdated
Show resolved
Hide resolved
| final IResourceNameIterator iter = newResourceNameIterator(path, locale, style, variation); | ||
| final IPropertiesFactory propertiesFactory = getPropertiesFactory(); | ||
|
|
||
| while (iter.hasNext()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use streams, not iterators
|
|
||
| mountPage("/login", getSignInPageClass()); | ||
|
|
||
| //[SYNCOPE-1942] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to comment with issue reference, we have git blame for this
| home=Home | ||
| version=Version | ||
| domain=Domain | ||
| domain=Domain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this space-adding change
| } | ||
| } | ||
|
|
||
| //[SYNCOPE-1942] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| public final class DynamicMenuRegister { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turn this class into a bean.
You can take https://github.com/apache/syncope/blob/master/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/MIMETypesLoader.java as reference
No description provided.