Skip to content

Conversation

@massx1
Copy link
Contributor

@massx1 massx1 commented Dec 30, 2025

No description provided.

@ilgrosso ilgrosso changed the title [SYNCOPE-1942] added getString to retrieve the label from localizatio… [SYNCOPE-1942] added getString to retrieve the label from localization properties file Dec 30, 2025
Copy link
Member

@ilgrosso ilgrosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides what reported above, the same approach should be applied to extPages in the same way

@ilgrosso
Copy link
Member

@massx1 welcome back!
Have you already linked your GitHub and ASF accounts by https://gitbox.apache.org/boxer/ ?

@massx1
Copy link
Contributor Author

massx1 commented Jan 2, 2026

@massx1 welcome back! Have you already linked your GitHub and ASF accounts by https://gitbox.apache.org/boxer/ ?

done

final IResourceNameIterator iter = newResourceNameIterator(path, locale, style, variation);
final IPropertiesFactory propertiesFactory = getPropertiesFactory();

while (iter.hasNext()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use streams, not iterators


mountPage("/login", getSignInPageClass());

//[SYNCOPE-1942]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to comment with issue reference, we have git blame for this

home=Home
version=Version
domain=Domain
domain=Domain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this space-adding change

}
}

//[SYNCOPE-1942]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

import java.util.HashMap;
import java.util.Map;

public final class DynamicMenuRegister {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants