Skip to content

Commit 0de6fab

Browse files
committed
[MINOR] Code cleanups in rewrites and tests, part II
1 parent e705f89 commit 0de6fab

File tree

7 files changed

+635
-663
lines changed

7 files changed

+635
-663
lines changed

.github/workflows/javaTests.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,16 @@ jobs:
116116

117117
determine_test_coverage:
118118
name: Determine Test Coverage
119-
needs: [java_tests]
119+
runs-on: ${{ matrix.os }}
120+
needs: [
121+
java_tests
122+
]
120123
strategy:
124+
fail-fast: false
121125
matrix:
122126
os: [ubuntu-latest]
123-
java: [11]
124-
127+
java: ['11']
128+
javadist: ['adopt']
125129
steps:
126130
- name: Checkout Repository
127131
uses: actions/checkout@v4

.github/workflows/python.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464
distribution: ${{ matrix.javadist }}
6565
java-version: ${{ matrix.java }}
6666
cache: 'maven'
67-
67+
6868
- name: Cache Pip Dependencies
6969
uses: actions/cache@v4
7070
with:
@@ -93,11 +93,11 @@ jobs:
9393
with:
9494
python-version: ${{ matrix.python-version }}
9595
architecture: 'x64'
96-
96+
9797
- name: Install pip Dependencies
9898
run: |
9999
# Install pip twice to update past the versions.
100-
pip install --upgrade pip
100+
pip install --upgrade pip
101101
pip install --upgrade pip
102102
pip install wheel
103103
pip install \
@@ -133,7 +133,7 @@ jobs:
133133
unittest-parallel -t . -s tests -v
134134
# python -m unittest discover -s tests -p 'test_*.py'
135135
echo "Exit Status: " $?
136-
136+
137137
- name: Run all python tests no environment
138138
run: |
139139
export LOG4JPROP=$(pwd)/src/test/resources/log4j.properties

0 commit comments

Comments
 (0)