Commit 0e3cce1
committed
[MINOR] Increase Memory Estimate for Frames
This commit increases the default estimate of frame size.
Previously, frames were estimated similarly to Matrices.
The wrong estimate leads to problems on frames of > Integer rows.
To improve it, this commit defaults to 8 character strings on all cells.
In an unread matrix.
Since there is no way of knowing if the input Frame contains longer
strings, it is still a subpar estimate. However,
it is an improvement overestimating everything as a dense double Matrix.
(The change happened because I encountered very incorrect estimates in BEWARE)1 parent 29b4d92 commit 0e3cce1
File tree
2 files changed
+17
-2
lines changed- src/main/java/org/apache/sysds/hops
2 files changed
+17
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
359 | 359 | | |
360 | 360 | | |
361 | 361 | | |
362 | | - | |
363 | | - | |
| 362 | + | |
| 363 | + | |
364 | 364 | | |
365 | 365 | | |
366 | 366 | | |
| |||
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
382 | 387 | | |
383 | 388 | | |
384 | 389 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
| |||
788 | 789 | | |
789 | 790 | | |
790 | 791 | | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
791 | 801 | | |
792 | 802 | | |
793 | 803 | | |
| |||
0 commit comments