Skip to content

Commit 15c6abe

Browse files
committed
[SYSTEMDS-3812] Fix pushdown-sum rewrite robustness for unknown dims
1 parent f3b638a commit 15c6abe

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/org/apache/sysds/hops/rewrite/RewriteAlgebraicSimplificationDynamic.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1396,7 +1396,7 @@ else if (right.getDim1() == 1 || right.getDim2() == 1) {
13961396
// Row vector case (1 x n)
13971397
if (right.getDim1() == 1) {
13981398
// Create nrow(A) operation using dimensions
1399-
LiteralOp nRows = new LiteralOp(left.getDim1());
1399+
UnaryOp nRows = HopRewriteUtils.createUnary(left, OpOp1.NROW);
14001400
BinaryOp scaledSum = HopRewriteUtils.createBinary(nRows, sum2, OpOp2.MULT);
14011401
BinaryOp newBin = HopRewriteUtils.createBinary(sum1, scaledSum, applyOp);
14021402
//rewire new subdag
@@ -1410,7 +1410,7 @@ else if (right.getDim1() == 1 || right.getDim2() == 1) {
14101410
// Column vector case (n x 1)
14111411
else if (right.getDim2() == 1) {
14121412
// Create ncol(A) operation using dimensions
1413-
LiteralOp nCols = new LiteralOp(left.getDim2());
1413+
UnaryOp nCols = HopRewriteUtils.createUnary(left, OpOp1.NCOL);
14141414
BinaryOp scaledSum = HopRewriteUtils.createBinary(nCols, sum2, OpOp2.MULT);
14151415
BinaryOp newBin = HopRewriteUtils.createBinary(sum1, scaledSum, applyOp);
14161416
//rewire new subdag

0 commit comments

Comments
 (0)