Skip to content

Commit 207c375

Browse files
committed
cleanup code
1 parent 1a75704 commit 207c375

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/main/java/org/apache/sysds/hops/codegen/cplan/CNodeBinary.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,10 +159,6 @@ public String codegen(boolean sparse, GeneratorAPI api) {
159159
sb.append(_inputs.get(0).codegen(sparse, api));
160160
sb.append(_inputs.get(1).codegen(sparse, api));
161161

162-
/**
163-
* todo: remember that only certain primitives will be called through this method,
164-
* because the optimizer will choose which primitive functions should be calculated sparse and which not
165-
*/
166162
if(DMLScript.SPARSE_INTERMEDIATE) {
167163
//generate binary operation (use sparse template, if data input)
168164
boolean lsparseLhs = sparse ? _inputs.get(0) instanceof CNodeData
@@ -206,7 +202,6 @@ public String codegen(boolean sparse, GeneratorAPI api) {
206202
&& TemplateUtils.isColVector(_inputs.get(j)))) && _type!=BinType.VECT_MATRIXMULT) ?
207203
varj + ".pos(rix)" : "0" : "0");
208204
}
209-
//todo: the following if else block could be simplified, because the first condition won't be true
210205
//replace length information (e.g., after matrix mult)
211206
if( _type == BinType.VECT_OUTERMULT_ADD || (_type == BinType.VECT_CBIND && vectorVector)) {
212207
for( int j=0; j<2; j++ )

0 commit comments

Comments
 (0)