Skip to content

Commit 2c7fb4b

Browse files
committed
[SYSTEMDS-3775] Revert components
This commit reverts the recent addition of components in the code coverage utility. Unfortunately, the components did more than anticipated, because they add more checks to the commits and were not visible in the PR that was trying their behavior. The intended behavior was to have coverage measurements and easy selection of sub-packages in the codecov webpage (this worked on the PR). Instead, it also added extra unintended 'Actions' that had to be passed for validation once merged to main. Furthermore, the Python upload of code coverage did not work once merged to main, therefore that change is reverted as well.
1 parent bbd79d2 commit 2c7fb4b

File tree

2 files changed

+3
-45
lines changed

2 files changed

+3
-45
lines changed

.github/workflows/python.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -128,15 +128,15 @@ jobs:
128128
export SYSDS_QUIET=1
129129
export LOG4JPROP=$SYSTEMDS_ROOT/src/test/resources/log4j.properties
130130
cd src/main/python
131-
unittest-parallel -t . -s tests -v --coverage-branch --coverage-xml .coverage.xml --coverage-source systemds
131+
unittest-parallel -t . -s tests -v
132132
# python -m unittest discover -s tests -p 'test_*.py'
133133
echo "Exit Status: " $?
134134
135135
- name: Run all python tests no environment
136136
run: |
137137
export LOG4JPROP=$(pwd)/src/test/resources/log4j.properties
138138
cd src/main/python
139-
unittest-parallel -t . -s tests -v --coverage-branch --coverage-xml .coverage.xml --coverage-source systemds
139+
unittest-parallel -t . -s tests -v
140140
# python -m unittest discover -s tests -p 'test_*.py'
141141
echo "Exit Status: " $?
142142
@@ -155,10 +155,4 @@ jobs:
155155
run: |
156156
black --check src/main/python/tests
157157
158-
- name: Upload coverage to Codecov
159-
uses: codecov/[email protected]
160-
if: github.repository_owner == 'apache'
161-
env:
162-
fail_ci_if_error: false
163-
files: src/main/python/.coverage.xml
164-
token: ${{ secrets.CODECOV_TOKEN }}
158+

codecov.yml

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -34,39 +34,3 @@ coverage:
3434
range: "50...75"
3535
ignore:
3636
- "src/main/java/org/apache/sysds/protobuf"
37-
component_management:
38-
default_rules: # default rules that will be inherited by all components
39-
statuses:
40-
- type: project # in this case every component that doesn't have a status defined will have a project type one
41-
target: auto
42-
individual_components:
43-
- component_id: module_runtime # this is an identifier that should not be changed
44-
name: runtime # this is a display name, and can be changed freely
45-
paths:
46-
- src/main/java/org/apache/sysds/runtime/**
47-
- component_id: module_matrix # this is an identifier that should not be changed
48-
name: matrix # this is a display name, and can be changed freely
49-
paths:
50-
- src/main/java/org/apache/sysds/runtime/matrix/**
51-
- component_id: module_frame # this is an identifier that should not be changed
52-
name: frame # this is a display name, and can be changed freely
53-
paths:
54-
- src/main/java/org/apache/sysds/runtime/frame/**
55-
- component_id: module_compress # this is an identifier that should not be changed
56-
name: compress # this is a display name, and can be changed freely
57-
paths:
58-
- src/main/java/org/apache/sysds/runtime/compress/**
59-
- component_id: module_compiler # this is an identifier that should not be changed
60-
name: compiler # this is a display name, and can be changed freely
61-
paths:
62-
- src/main/java/org/apache/sysds/hops/**
63-
- src/main/java/org/apache/sysds/lops/**
64-
- src/main/java/org/apache/sysds/parser/**
65-
- component_id: module_util # this is an identifier that should not be changed
66-
name: util # this is a display name, and can be changed freely
67-
paths:
68-
- src/main/java/org/apache/sysds/api/**
69-
- src/main/java/org/apache/sysds/common/**
70-
- src/main/java/org/apache/sysds/conf/**
71-
- src/main/java/org/apache/sysds/resource/**
72-
- src/main/java/org/apache/sysds/utils/**

0 commit comments

Comments
 (0)