safe cast

Author: Baunsgaard

src/main/java/org/apache/sysds/runtime/frame/data/columns/StringArray.java

@@ -607,7 +607,6 @@ public double getAsNaNDouble(int i) {
 
 	private static double getAsDouble(String s) {
 		try {
-
 			return DoubleArray.parseDouble(s);
 		}
 		catch(Exception e) {

src/main/java/org/apache/sysds/runtime/frame/data/lib/MatrixBlockFromFrame.java

@@ -94,10 +94,19 @@ else if(ret.getNumRows() != m || ret.getNumColumns() != n || ret.isInSparseForma
 	}
 
 	private static long convert(FrameBlock frame, MatrixBlock mb, int n, int rl, int ru) {
-		if(mb.getDenseBlock().isContiguous())
-			return convertContiguous(frame, mb, n, rl, ru);
-		else
-			return convertGeneric(frame, mb, n, rl, ru);
+		try {
+
+			if(mb.getDenseBlock().isContiguous())
+				return convertContiguous(frame, mb, n, rl, ru);
+			else
+				return convertGeneric(frame, mb, n, rl, ru);
+		}
+		catch(NumberFormatException e) {
+			LOG.error(
+				"Failed to convert to Matrix because of number format errors, falling back to NaN on incompatible cells",
+				e);
+			return convertSafeCast(frame, mb, n, rl, ru);
+		}
 	}
 
 	private static long convertParallel(FrameBlock frame, MatrixBlock mb, int m, int n, int k) throws Exception {
@@ -169,4 +178,39 @@ private static long convertBlockGeneric(final FrameBlock frame, long lnnz, final
 		}
 		return lnnz;
 	}
+
+
+
+	private static long convertSafeCast(final FrameBlock frame, final MatrixBlock mb, final int n, final int rl, final int ru){
+		final DenseBlock c = mb.getDenseBlock();
+		long lnnz = 0;
+		for(int bi = rl; bi < ru; bi += blocksizeIJ) {
+			for(int bj = 0; bj < n; bj += blocksizeIJ) {
+				int bimin = Math.min(bi + blocksizeIJ, ru);
+				int bjmin = Math.min(bj + blocksizeIJ, n);
+				lnnz = convertBlockSafeCast(frame, lnnz, c, bi, bj, bimin, bjmin);
+			}
+		}
+		return lnnz;
+	}
+
+
+	private static long convertBlockSafeCast(final FrameBlock frame, long lnnz, final DenseBlock c, final int rl,
+		final int cl, final int ru, final int cu) {
+		for(int i = rl; i < ru; i++) {
+			final double[] cvals = c.values(i);
+			final int cpos = c.pos(i);
+			for(int j = cl; j < cu; j++){
+				try{
+					lnnz += (cvals[cpos + j] = frame.getDoubleNaN(i, j)) != 0 ? 1 : 0;
+				}
+				catch(NumberFormatException e){
+					lnnz += 1;
+					cvals[cpos + j] = Double.NaN;
+				}
+			}
+		}
+		return lnnz;
+	}
+
 }