Skip to content

Commit 594bfc5

Browse files
committed
Set bareiss algorithm as strategy
1 parent 391827b commit 594bfc5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/main/java/org/apache/sysds/hops/rewrite/RewriteAlgebraicSimplificationStatic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ private void rule_AlgebraicSimplification(Hop hop, boolean descendFirst)
167167
hi = pushdownUnaryAggTransposeOperation(hop, hi, i); //e.g., colSums(t(X)) -> t(rowSums(X))
168168
hi = pushdownCSETransposeScalarOperation(hop, hi, i);//e.g., a=t(X), b=t(X^2) -> a=t(X), b=t(X)^2 for CSE t(X)
169169
hi = pushdownDetMultOperation(hop, hi, i); //e.g., det(X%*%Y) -> det(X)*det(Y)
170-
hi = pushdownDetScalarMatrixMultOperation(hop, hi, i); //e.g., det(lambda*X) -> lambda^nrow*det(X)
170+
hi = pushdownDetScalarMatrixMultOperation(hop, hi, i); //e.g., det(lambda*X) -> lambda^nrow(X)*det(X)
171171
hi = pushdownSumBinaryMult(hop, hi, i); //e.g., sum(lambda*X) -> lambda*sum(X)
172172
hi = pullupAbs(hop, hi, i); //e.g., abs(X)*abs(Y) --> abs(X*Y)
173173
hi = simplifyUnaryPPredOperation(hop, hi, i); //e.g., abs(ppred()) -> ppred(), others: round, ceil, floor

src/main/java/org/apache/sysds/runtime/matrix/data/LibCommonsMath.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,7 @@ private static MatrixBlock computeDeterminant(Array2DRowRealMatrix in) {
579579
final int useGaussianStrategy = 1;
580580
final int useBareissStrategy = 2;
581581
final int useLaplaceStrategy = 3;
582-
int computationStrategy = useGaussianStrategy;
582+
int computationStrategy = useBareissStrategy;
583583

584584
double determinant = 0;
585585
switch (computationStrategy) {

0 commit comments

Comments
 (0)