Skip to content

Commit aa4ce0b

Browse files
committed
[MINOR] BinaryOp change to switch statement
1 parent a6d8bc0 commit aa4ce0b

File tree

1 file changed

+40
-11
lines changed

1 file changed

+40
-11
lines changed

src/main/java/org/apache/sysds/hops/BinaryOp.java

Lines changed: 40 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1154,20 +1154,49 @@ && getInput().get(0) == that2.getInput().get(0)
11541154
}
11551155

11561156
public boolean supportsMatrixScalarOperations() {
1157-
return ( op==OpOp2.PLUS ||op==OpOp2.MINUS
1158-
||op==OpOp2.MULT ||op==OpOp2.DIV
1159-
||op==OpOp2.MODULUS ||op==OpOp2.INTDIV
1160-
||op==OpOp2.LESS ||op==OpOp2.LESSEQUAL
1161-
||op==OpOp2.GREATER ||op==OpOp2.GREATEREQUAL
1162-
||op==OpOp2.EQUAL ||op==OpOp2.NOTEQUAL
1163-
||op==OpOp2.MIN ||op==OpOp2.MAX
1164-
||op==OpOp2.LOG ||op==OpOp2.POW
1165-
||op==OpOp2.AND ||op==OpOp2.OR ||op==OpOp2.XOR
1166-
||op==OpOp2.BITWAND ||op==OpOp2.BITWOR ||op==OpOp2.BITWXOR
1167-
||op==OpOp2.BITWSHIFTL ||op==OpOp2.BITWSHIFTR);
1157+
switch(op) {
1158+
case PLUS:
1159+
case MINUS:
1160+
case MULT:
1161+
case DIV:
1162+
case MODULUS:
1163+
case INTDIV:
1164+
case LESS:
1165+
case LESSEQUAL:
1166+
case GREATER:
1167+
case GREATEREQUAL:
1168+
case EQUAL:
1169+
case NOTEQUAL:
1170+
case MIN:
1171+
case MAX:
1172+
case LOG:
1173+
case POW:
1174+
case AND:
1175+
case OR:
1176+
case XOR:
1177+
case BITWAND:
1178+
case BITWOR:
1179+
case BITWXOR:
1180+
case BITWSHIFTL:
1181+
case BITWSHIFTR:
1182+
return true;
1183+
default:
1184+
return false;
1185+
}
11681186
}
11691187

11701188
public boolean isPPredOperation() {
1189+
switch(op){
1190+
case LESS:
1191+
case LESSEQUAL:
1192+
case GREATER:
1193+
case GREATEREQUAL:
1194+
case EQUAL:
1195+
case NOTEQUAL:
1196+
return true;
1197+
default :
1198+
return false;
1199+
}
11711200
return (op==OpOp2.LESS ||op==OpOp2.LESSEQUAL
11721201
||op==OpOp2.GREATER ||op==OpOp2.GREATEREQUAL
11731202
||op==OpOp2.EQUAL ||op==OpOp2.NOTEQUAL);

0 commit comments

Comments
 (0)