Skip to content

Commit b859d4b

Browse files
committed
unsafe and safe
1 parent 4f32ca9 commit b859d4b

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

src/main/java/org/apache/sysds/runtime/frame/data/columns/BitSetArray.java

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -107,26 +107,26 @@ public synchronized void set(int index, boolean value) {
107107
@Override
108108
public void setNullsFromString(int rl, int ru, Array<String> value) {
109109

110-
final boolean unsafe = ru % 64 != 0 || rl % 64 != 0;
110+
// final boolean unsafe = ru % 64 != 0 || rl % 64 != 0;
111111
// ensure that it is safe to modify the values in the ranges.
112112

113-
if(unsafe) {
114-
// find rl rounded up to start safe
115-
final int rl64 = Math.min((rl / 64 + 1) * 64, ru);
116-
final int ru64 = (ru / 64) * 64;
117-
118-
for(int i = rl; i < rl64; i++)
119-
unsafeSet(i, value.get(i) != null);
120-
for(int i = rl64; i < ru64; i++)
121-
set(i, value.get(i) != null);
122-
for(int i = ru64; i < ru; i++)
123-
unsafeSet(i, value.get(i) != null);
124-
}
125-
else {
126-
// safe all the way
127-
for(int i = rl; i < ru; i++)
128-
set(i, value.get(i) != null);
129-
}
113+
// if(unsafe) {
114+
// find rl rounded up to start safe
115+
final int rl64 = Math.min((rl / 64 + 1) * 64, ru);
116+
final int ru64 = (ru / 64) * 64;
117+
118+
for(int i = rl; i < rl64; i++)
119+
set(i, value.get(i) != null);
120+
for(int i = rl64; i < ru64; i++)
121+
unsafeSet(i, value.get(i) != null);
122+
for(int i = ru64; i < ru; i++)
123+
set(i, value.get(i) != null);
124+
// }
125+
// else {
126+
// // safe all the way
127+
// for(int i = rl; i < ru; i++)
128+
// set(i, value.get(i) != null);
129+
// }
130130
}
131131

132132
private void unsafeSet(int index, boolean value) {

0 commit comments

Comments
 (0)