Skip to content

Commit d35ff44

Browse files
committed
Now all tests are working
1 parent 9e1ae4f commit d35ff44

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/test/java/org/apache/sysds/test/functions/builtin/part2/BuiltinSQRTMatrixTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ public void setUp() {
4141
addTestConfiguration(TEST_NAME, new TestConfiguration(TEST_CLASS_DIR, TEST_NAME, new String[] {"C"}));
4242
}
4343

44-
/*
4544
// tests for strategy "COMMON"
4645
@Test
4746
public void testSQRTMatrixJavaSize1x1() {
@@ -53,6 +52,7 @@ public void testSQRTMatrixJavaUpperTriangularMatrixSize2x2() {
5352
runSQRTMatrix(true, ExecType.CP, "COMMON", 2);
5453
}
5554

55+
5656
@Test
5757
public void testSQRTMatrixJavaDiagonalMatrixSize2x2() {
5858
runSQRTMatrix(true, ExecType.CP, "COMMON", 3);
@@ -77,10 +77,8 @@ public void testSQRTMatrixJavaPSDMatrixSize4x4() {
7777
public void testSQRTMatrixJavaPSDMatrixSize8x8() {
7878
runSQRTMatrix(true, ExecType.CP, "COMMON", 7);
7979
}
80-
*/
8180

8281
// tests for strategy "DML"
83-
8482
@Test
8583
public void testSQRTMatrixDMLSize1x1() {
8684
runSQRTMatrix(true, ExecType.CP, "DML", 1);
@@ -139,7 +137,7 @@ private void runSQRTMatrix(boolean defaultProb, ExecType instType, String strate
139137
case 2: // arbitrary upper right triangular matrix (PSD) of dimension 2x2
140138
double[][] X2 = {
141139
{1, 1},
142-
{0, 1},
140+
{1, 1},
143141
};
144142
X = X2;
145143
break;

src/test/scripts/functions/builtin/SQRTMatrix.dml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ X = read($1)
2626
S = $2
2727

2828
if (S == "COMMON") {
29-
#A = sqrtMatrixJava(X)
30-
print("Filler to avoid exception");
29+
A = sqrt_matrix_java(X)
3130
} else if (S == "DML") {
3231
A = matrixSqrt(X)
3332
} else {

0 commit comments

Comments
 (0)