Skip to content

Commit d40482a

Browse files
committed
- removed relaxed compression threshold
- added logging statement if it would be useful to implement compressed binary matrix-vector op with left true
1 parent 869ef98 commit d40482a

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/main/java/org/apache/sysds/runtime/compress/CompressedMatrixBlockFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ private void coCodePhase() {
382382

383383
logPhase();
384384
// if cocode is estimated larger than uncompressed abort compression.
385-
if(_stats.estimatedCostCoCoded > _stats.originalCost*2) {
385+
if(_stats.estimatedCostCoCoded > _stats.originalCost) {
386386
// abort compression
387387
compressionGroups = null;
388388
if(LOG.isInfoEnabled()) {
@@ -459,7 +459,7 @@ private void finalizePhase() {
459459
_stats.compressedCost = costEstimator.getCost(res.getColGroups(), res.getNumRows());
460460
_stats.setColGroupsCounts(res.getColGroups());
461461

462-
if(_stats.compressedCost > _stats.originalCost*2) {
462+
if(_stats.compressedCost > _stats.originalCost) {
463463
LOG.info("--dense size: " + _stats.denseSize);
464464
LOG.info("--original size: " + _stats.originalSize);
465465
LOG.info("--compressed size: " + _stats.compressedSize);

src/main/java/org/apache/sysds/runtime/compress/lib/CLALibBinaryCellOp.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -421,9 +421,13 @@ private static MatrixBlock mvColCompressed(CompressedMatrixBlock m1, MatrixBlock
421421

422422
}
423423

424-
if(estNnzPerRow <= 2 && nCols <= 32 && op.fn instanceof ValueComparisonFunction && !left){
425-
return k <= 1 ? binaryMVComparisonColSingleThreadCompressed(m1, m2, op) :
424+
if(estNnzPerRow <= 2 && nCols <= 32 && op.fn instanceof ValueComparisonFunction){
425+
if(!left)
426+
return k <= 1 ? binaryMVComparisonColSingleThreadCompressed(m1, m2, op) :
426427
binaryMVComparisonColMultiCompressed(m1, m2, op);
428+
else
429+
LOG.debug("Compressed binary matrix-vector op left is not supported yet,\n" +
430+
"fallback to generic binary matrix-vector op");
427431
}
428432
MatrixBlock ret = new MatrixBlock(nRows, nCols, shouldBeSparseOut, -1).allocateBlock();
429433

0 commit comments

Comments
 (0)