Skip to content

Commit e868917

Browse files
committed
[MINOR] Docker Guide Update
1 parent 3f3ddb3 commit e868917

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

docker/README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,22 +31,22 @@ To Build the docker image simply run the build script.
3131
./docker/build.sh
3232
```
3333

34-
Afterwards you should have a local image with the id `systemds/sysds:latest`.
34+
Afterwards you should have a local image with the id `apache/systemds:latest`.
3535
To execute any given DML script follow the step Run.
3636

3737
## Run
3838

3939
Running SystemDS in a docker container is as simple as constructing any DML script.
40-
Then download the docker image `systemds/sysds:latest` or build your own.
40+
Then download the docker image `apache/systemds:latest` or build your own.
4141

4242
```bash
43-
docker pull systemds/sysds:latest
43+
docker pull apache/systemds:latest
4444
```
4545

4646
Verify that the docker image correctly works simply by running it.
4747

4848
```bash
49-
docker run --rm systemds/sysds:latest
49+
docker run --rm apache/systemds:latest
5050
```
5151

5252
It should respond with something like:
@@ -65,7 +65,7 @@ You can mount any such folder and execute systemds by changing the first part of
6565
```bash
6666
docker run \
6767
-v $(pwd)/docker/mountFolder:/input \
68-
--rm systemds/sysds:latest
68+
--rm apache/systemds:latest
6969
```
7070

7171
Default behavior is to run the script located at /input/main.dml.
@@ -74,7 +74,7 @@ To run any other script use:
7474
```bash
7575
docker run \
7676
-v $(pwd)/folder/to/share:/any/path/in/docker/instance \
77-
--rm systemds/sysds:latest \
77+
--rm apache/systemds:latest \
7878
systemds /any/path/to/a/script.dml
7979
```
8080

@@ -83,7 +83,7 @@ docker run \
8383
To run a federated worker in a docker container simply use:
8484

8585
```bash
86-
docker run -p 8000:8000 --rm systemds/sysds:latest systemds WORKER 8000
86+
docker run -p 8000:8000 --rm apache/systemds:latest systemds WORKER 8000
8787
```
8888

8989
This port forwards the worker to port 8000 on the host and starts a worker in the instance on port 8000.
@@ -95,23 +95,23 @@ To add a folder containing the data needed in the worker do the following:
9595
docker run \
9696
-p 8000:8000 \
9797
-v $(pwd)/data/folder/path/locally:/data/folder/path/in/container \
98-
--rm systemds/sysds:latest systemds WORKER 8000
98+
--rm apache/systemds:latest systemds WORKER 8000
9999
```
100100

101101
### Docker run python script
102102

103103
To run a python script the `pythonsysds` image is used.
104104

105105
```bash
106-
docker run --rm systemds/pythonsysds:latest
106+
docker run --rm apache/systemds:python-nightly
107107
```
108108

109109
User provided scripts have to be mounted into the image.
110110

111111
```bash
112112
docker run \
113113
-v $(pwd)/data/folder/path/locally:/data/folder/path/in/container \
114-
--rm systemds/pythonsystds:latest \
114+
--rm apache/systemds:latest \
115115
python3 path/to/script/to/execute.py
116116
```
117117

@@ -128,7 +128,7 @@ To build this image simply run the same command as above.
128128
Because the github action pulls the image from docker hub the image has to be pushed to docker hub to produce any change in the behavior of the testing.
129129

130130
```bash
131-
docker push systemds/testingsysds:latest
131+
docker push apache/systemds:testing-latest
132132
```
133133

134134
For each of the tests that require R, this image is simply used, because it skips the installation of the R packages, since they are installed in this image.
@@ -138,6 +138,6 @@ Test your testing image locally by running the following command:
138138
```bash
139139
docker run \
140140
-v $(pwd):/github/workspace \
141-
systemds/testingsysds:latest \
141+
apache/systemds:testing-latest \
142142
org.apache.sysds.test.component.**
143143
```

docker/build.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#/bin/bash
1+
#!/usr/bin/env bash
22
#-------------------------------------------------------------
33
#
44
# Licensed to the Apache Software Foundation (ASF) under one
@@ -23,13 +23,13 @@
2323
# Build the docker containers
2424

2525
# The first build is for running systemds through docker.
26-
docker image build -f docker/sysds.Dockerfile -t apache/systemds:nightly .
26+
docker image build -f docker/sysds.Dockerfile -t apache/systemds:latest .
2727

2828
# The second build is for testing systemds. This image installs the R dependencies needed to run the tests.
2929
docker image build -f docker/testsysds.Dockerfile -t apache/systemds:testing-latest .
3030

3131
# The third build is python docker for systemds.
32-
docker image build -f docker/pythonsysds.Dockerfile -t apache/systemds:python-nightly .
32+
# docker image build -f docker/pythonsysds.Dockerfile -t apache/systemds:python-nightly .
3333

3434
# You might want to prune the docker system afterwards using
3535
# docker system prune

0 commit comments

Comments
 (0)