Skip to content

Commit 66e0b6a

Browse files
yunyadMA77HEW820
authored andcommitted
Fix Issue with lifecycle removing Incorrect files and losing result content (#3223)
This PR resolves the issue where storage documents for results randomly disappear. The root cause of this problem lies in the lifecycle fetching the wrong file to remove. The lifecycle currently retrieves the latest execution ID from the database but does so without considering the workflow ID. This results in the lifecycle incorrectly identifying files for removal, leading to the loss of result content. With this fix, the lifecycle now ensures that the execution ID is fetched in the context of the corresponding workflow ID.
1 parent 9bfcc41 commit 66e0b6a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

core/amber/src/main/scala/edu/uci/ics/texera/web/resource/dashboard/user/workflow/WorkflowExecutionsResource.scala

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,9 @@ object WorkflowExecutionsResource {
8383
val executions = context
8484
.select(WORKFLOW_EXECUTIONS.EID)
8585
.from(WORKFLOW_EXECUTIONS)
86+
.join(WORKFLOW_VERSION)
87+
.on(WORKFLOW_EXECUTIONS.VID.eq(WORKFLOW_VERSION.VID))
88+
.where(WORKFLOW_VERSION.WID.eq(wid))
8689
.fetchInto(classOf[UInteger])
8790
.asScala
8891
.toList

0 commit comments

Comments
 (0)