Skip to content

Commit d4b23ff

Browse files
Add nodejs tests to CI
These tests exist, but don't currently run on CI. This has caused regressions, such as in #3014. Note these do not use make to run them, as much of the other tests do.
1 parent 645467e commit d4b23ff

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

.github/workflows/build.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -519,6 +519,27 @@ jobs:
519519
- name: Run make check for python
520520
run: make -C lib/py check
521521

522+
lib-nodejs:
523+
needs: compiler
524+
runs-on: ubuntu-24.04
525+
steps:
526+
- uses: actions/checkout@v4
527+
528+
- name: Run bootstrap
529+
run: ./bootstrap.sh
530+
531+
- name: Run configure
532+
run: |
533+
./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-nodejs/with-nodejs/')
534+
535+
- uses: actions/download-artifact@v4
536+
with:
537+
name: thrift-compiler
538+
path: compiler/cpp
539+
540+
- name: Run tests
541+
run: ./lib/nodejs/test/testAll.sh
542+
522543
cross-test:
523544
needs:
524545
- lib-java-kotlin

0 commit comments

Comments
 (0)