Fixed C++ cppcheck offenses

Author: kpumuk

compiler/cpp/src/thrift/generate/t_c_glib_generator.cc

@@ -76,14 +76,13 @@ class t_c_glib_generator : public t_oop_generator {
       this->nspace_lc = "";
     } else {
       /* replace dots with underscores */
-      char* tmp = strdup(this->nspace.c_str());
-      for (unsigned int i = 0; i < strlen(tmp); i++) {
+      string tmp = this->nspace;
+      for (size_t i = 0; i < tmp.size(); i++) {
         if (tmp[i] == '.') {
           tmp[i] = '_';
         }
       }
-      this->nspace = string(tmp, strlen(tmp));
-      free(tmp);
+      this->nspace = tmp;
 
       /* clean up the namespace for C.
        * An input of 'namespace foo' should result in:

lib/cpp/test/TFileTransportTest.cpp

@@ -67,8 +67,8 @@ class FsyncLog {
   FsyncLog() = default;
 
   void fsync(int fd) {
-    (void)fd;
     FsyncCall call;
+    call.fd = fd;
     THRIFT_GETTIMEOFDAY(&call.time, nullptr);
     calls_.push_back(call);
   }