* Added GremlinLang to go driver to replace Bytecode. Clean up and updates will be needed when connection is set up.

* update graph binary serializer to 4.0.0 spec
* Updated datetime, added GValue, updated Options strategy, removed unneeded strategy package name, added NewTraversalStrategy to allow custom strategies. (#3056)
* Replace websockets with http. Changed connection pooling to be delegated to aio http library. Added POC changes to request serialization just to make happy path work. Full connection configuration and response chunking not yet implemented. (#3057)
* update gremlinlang to use slices to store instructions instead
* update strategies test after gremlinlang change
* update serializer to use marker
* fix strategies translation and add missing strategies
* Remove result set map container as it is no longer needed.
* Removed concept of session as it is no longer needed.
* Read response status code from graph binary response.
* Removed response status attributes as they no longer exist.
* Read response status message and exception strings.
* Remove gremlin-socket-server from docker compose.
* Removed socket server tests.
* Changed transporter to delegate most of the request creation to client library by using http.NewRequest. Removed requestId as it's no longer used. Made some small logging changes.
* Removed unused request op attribute.
* Removed unused request processor.
* Added some comments, refactored error handling and resource closing.
* Removed reference to partial content status code. Added some comments and did some minor cleanup.
* Removed reference to response metadata.
* Removed unused synchronized mpa.
* Removed tests for custom type serialization. Removed response id as it is no longer used. Adjusted expected serialized request bytes according to TP4 format. Adjusted bytes for testing deserialization according to TP4 format. Removed serializer unwrapping of single item results as it was causing serialization test to fail. (#3066)

fix various gremlinlang and serializer bugs in go for http

Author: xiazcy

.github/workflows/build-test.yml

@@ -354,40 +354,28 @@ jobs:
         run: |
           mvn clean install -pl $EXCLUDE_MODULES -q -DskipTests -Dci
           mvn verify -pl :neo4j-gremlin -DincludeNeo4j
-#  go:
-#    name: go
-#    timeout-minutes: 20
-#    needs: cache-gremlin-server-docker-image
-#    runs-on: ubuntu-latest
-#    steps:
-#      - name: Checkout
-#        uses: actions/checkout@v5
-#      - name: Setup Go
-#        uses: actions/setup-go@v5
-#        with:
-#          go-version: '1.25'
-#      - name: Get Cached Server Base Image
-#        uses: actions/cache@v4
-#        id: gremlin-server-test-docker-image
-#        with:
-#          path: |
-#            ./gremlin-server/*
-#            ~/.m2/repository/org/apache/tinkerpop/*
-#          key: ${{ github.sha }}
-#      - name: Load Docker Image
-#        working-directory: ./gremlin-server
-#        run: docker load --input gremlin-server.tar
-#      - name: Build with Maven
-#        working-directory: .
-#        run: |
-#          touch gremlin-go/.glv
-#          EXCLUDE="${EXCLUDE_MODULES/,-:gremlin-python},$EXCLUDE_FOR_GLV"
-#          mvn clean install -pl $EXCLUDE -q -DskipTests -Dci
-#          mvn verify -pl :gremlin-go
-#      - name: Upload to Codecov
-#        uses: codecov/codecov-action@v5
-#        with:
-#          working-directory: ./gremlin-go
-#      - name: Go-Vet
-#        working-directory: ./gremlin-go
-#        run: go vet ./...
+  go:
+    name: go
+    timeout-minutes: 20
+    needs: cache-gremlin-server-docker-image
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+      - name: Setup Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.25'
+      - name: Build with Maven
+        working-directory: .
+        run: |
+          touch gremlin-go/.glv
+          EXCLUDE="${EXCLUDE_MODULES/,-:gremlin-python},$EXCLUDE_FOR_GLV"
+          mvn clean install -pl $EXCLUDE -q -DskipTests -Dci
+          mvn verify -pl :gremlin-go
+      - name: Upload to Codecov
+        uses: codecov/codecov-action@v5
+        with:
+          working-directory: ./gremlin-go
+      - name: Go-Vet
+        working-directory: ./gremlin-go
+        run: go vet ./...

gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/translator/GoTranslateVisitor.java

@@ -23,6 +23,7 @@
 import org.antlr.v4.runtime.tree.TerminalNode;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.tinkerpop.gremlin.language.grammar.GremlinParser;
+import org.apache.tinkerpop.gremlin.process.traversal.TraversalStrategy;
 import org.apache.tinkerpop.gremlin.process.traversal.strategy.decoration.OptionsStrategy;
 import org.apache.tinkerpop.gremlin.structure.VertexProperty;
 import org.apache.tinkerpop.gremlin.util.DatetimeHelper;
@@ -41,7 +42,8 @@ public class GoTranslateVisitor extends AbstractTranslateVisitor {
     private final static List<String> STRATEGY_WITH_MAP_OPTS = Collections.unmodifiableList(Arrays.asList(
             "OptionsStrategy",
             "ReferenceElementStrategy", "ComputerFinalizationStrategy", "ProfileStrategy",
-            "ComputerVerificationStrategy", "StandardVerificationStrategy", "VertexProgramRestrictionStrategy"));
+            "ComputerVerificationStrategy", "StandardVerificationStrategy", "VertexProgramRestrictionStrategy",
+            "MessagePassingReductionStrategy"));
     private final static List<String> STRATEGY_WITH_STRING_SLICE = Collections.unmodifiableList(Arrays.asList(
             "ReservedKeysVerificationStrategy", "ProductiveByStrategy"));
 

gremlin-go/build/generate.groovy

@@ -121,9 +121,6 @@ radishGremlinFile.withWriter('UTF-8') { Writer writer ->
     '           traversalFn := traversalFns[0]\n' +
     '           translationMap[scenarioName] = traversalFns[1:]\n' +
     '           traversal := traversalFn(g, parameters)\n' +
-    '           for key, value := range sideEffects {\n' +
-    '               traversal.Bytecode.AddSource("withSideEffect", key, value)\n' +
-    '           }\n' +
     '           return traversal, nil\n' +
     '       } else {\n' +
     '           return nil, errors.New("scenario for traversal not recognized")\n' +

gremlin-go/driver/anonymousTraversal.go

@@ -337,7 +337,7 @@ type anonymousTraversal struct {
 
 var T__ AnonymousTraversal = &anonymousTraversal{
 	func() *GraphTraversal {
-		return NewGraphTraversal(nil, NewBytecode(nil), nil)
+		return NewGraphTraversal(nil, NewGremlinLang(nil), nil)
 	},
 }
 

gremlin-go/driver/authInfo.go

@@ -89,7 +89,7 @@ func (d *DynamicAuth) GetHeader() http.Header {
 	return d.fn().GetHeader()
 }
 
-// GetHeader calls the stored function to get basic authentication dynamically.
+// GetBasicAuth calls the stored function to get basic authentication dynamically.
 func (d *DynamicAuth) GetBasicAuth() (bool, string, string) {
 	return d.fn().GetBasicAuth()
 }