Skip to content

Commit 0565164

Browse files
authored
Clean up certifier SslData destructor (#12678)
Remove the commented-out debug statement from the SslData destructor. This statement was commented out in PR #9792 as a stop-gap measure because it was causing crashes during shutdown when accessing the potentially-destroyed dbg_ctl static object. Let's close the associated issue by just removing the commented out debug statement since it is generally considered unsafe to log in a destructor precisely because of its use of static structures which can surface order-dependent issues like the one reported in #9794. That is, not logging in the destructor is the correct solution, so let's just make @maskit's patch official. Fixes: #9794
1 parent 734f992 commit 0565164

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

plugins/certifier/certifier.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,8 @@ class SslLRUList
106106
SslData *prev = nullptr;
107107
SslData *next = nullptr;
108108

109-
SslData() = default;
110-
~SslData() { /* Dbg(dbg_ctl, "Deleting ssl data for [%s]", commonName.c_str()); */ }
109+
SslData() = default;
110+
~SslData() = default;
111111
};
112112

113113
using scoped_SslData = std::unique_ptr<SslLRUList::SslData>;

0 commit comments

Comments
 (0)