Fix double destuct on Http2Stream termination (#7600)

maskit · zwoop · commit 05bc1bf0f8a4 · 2021-05-26T09:48:48.000-06:00
The bug was introduced by #7584. (cherry picked from commit 94851be)
diff --git a/proxy/http2/Http2Stream.cc b/proxy/http2/Http2Stream.cc
@@ -485,7 +485,6 @@ Http2Stream::terminate_if_possible()
 
     Http2ClientSession *h2_proxy_ssn = static_cast<Http2ClientSession *>(this->_proxy_ssn);
     SCOPED_MUTEX_LOCK(lock, h2_proxy_ssn->connection_state.mutex, this_ethread());
-    this->~Http2Stream();
     THREAD_FREE(this, http2StreamAllocator, this_ethread());
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -485,7 +485,6 @@ Http2Stream::terminate_if_possible()`
`485`	`485`
`486`	`486`	`Http2ClientSession h2_proxy_ssn = static_cast<Http2ClientSession >(this->_proxy_ssn);`
`487`	`487`	`SCOPED_MUTEX_LOCK(lock, h2_proxy_ssn->connection_state.mutex, this_ethread());`
`488`		`- this->~Http2Stream();`
`489`	`488`	`THREAD_FREE(this, http2StreamAllocator, this_ethread());`
`490`	`489`	`}`
`491`	`490`	`}`