Require and call destructors on ClassAllocated objects (#12676)

* Update ClassAllocator to require and call destructors on ClassAllocated objects

* Cleanup and add HttpSM destructor

* The two classes that are now destructed that were previously cleaned up manually are cripts::Context and HttpSM

Author: cmcfarlen

include/iocore/eventsystem/Event.h

@@ -289,7 +289,7 @@ class Event : public Action
 //
 // Event Allocator
 //
-extern ClassAllocator<Event> eventAllocator;
+extern ClassAllocator<Event, false> eventAllocator;
 
 inline void
 Event::free()

include/iocore/eventsystem/IOBuffer.h

@@ -251,7 +251,7 @@ class IOBufferData : public RefCountObj
   IOBufferData &operator=(const IOBufferData &) = delete;
 };
 
-extern ClassAllocator<IOBufferData> ioDataAllocator;
+extern ClassAllocator<IOBufferData, false> ioDataAllocator;
 
 /**
   A linkable portion of IOBufferData. IOBufferBlock is a chainable
@@ -494,7 +494,7 @@ class IOBufferBlock : public RefCountObj
   IOBufferBlock &operator=(const IOBufferBlock &) = delete;
 };
 
-extern ClassAllocator<IOBufferBlock> ioBlockAllocator;
+extern ClassAllocator<IOBufferBlock, false> ioBlockAllocator;
 
 /** A class for holding a chain of IO buffer blocks.
     This class is intended to be used as a member variable for other classes that

include/iocore/eventsystem/Lock.h

@@ -247,7 +247,7 @@ class ProxyMutex : public RefCountObj
 };
 
 // The ClassAllocator for ProxyMutexes
-extern ClassAllocator<ProxyMutex> mutexAllocator;
+extern ClassAllocator<ProxyMutex, false> mutexAllocator;
 
 inline bool
 Mutex_trylock(

include/iocore/utils/OneWayMultiTunnel.h

@@ -131,4 +131,4 @@ struct OneWayMultiTunnel : public OneWayTunnel {
   VIO              *vioTargets[ONE_WAY_MULTI_TUNNEL_LIMIT];
 };
 
-extern ClassAllocator<OneWayMultiTunnel> OneWayMultiTunnelAllocator;
+extern ClassAllocator<OneWayMultiTunnel, false> OneWayMultiTunnelAllocator;

include/proxy/http/Http1ClientSession.h

@@ -130,4 +130,4 @@ class Http1ClientSession : public ProxySession
   Http1ClientTransaction trans;
 };
 
-extern ClassAllocator<Http1ClientSession, true> http1ClientSessionAllocator;
+extern ClassAllocator<Http1ClientSession> http1ClientSessionAllocator;

include/proxy/http/Http1ServerSession.h

@@ -105,7 +105,7 @@ class Http1ServerSession : public PoolableSession
   Http1ServerTransaction trans;
 };
 
-extern ClassAllocator<Http1ServerSession, true> httpServerSessionAllocator;
+extern ClassAllocator<Http1ServerSession> httpServerSessionAllocator;
 
 ////////////////////////////////////////////
 // INLINE

include/proxy/http/HttpSM.h

@@ -187,7 +187,7 @@ class HttpSM : public Continuation, public PluginUserArgs<TS_USER_ARGS_TXN>
 
 public:
   HttpSM();
-  void         cleanup();
+  ~HttpSM() override;
   virtual void destroy();
 
   static HttpSM   *allocate();

include/proxy/http/HttpTransact.h

@@ -851,6 +851,8 @@ class HttpTransact
       //      memset((void *)&host_db_info, 0, sizeof(host_db_info));
     }
 
+    ~State() { destroy(); }
+
     void
     destroy()
     {
@@ -859,8 +861,10 @@ class HttpTransact
       free_internal_msg_buffer();
       ats_free(internal_msg_buffer_type);
 
-      ParentConfig::release(parent_params);
-      parent_params = nullptr;
+      if (parent_params != nullptr) {
+        ParentConfig::release(parent_params);
+        parent_params = nullptr;
+      }
 
       hdr_info.client_request.destroy();
       hdr_info.client_response.destroy();
@@ -879,7 +883,6 @@ class HttpTransact
       url_map.clear();
       arena.reset();
       unmapped_url.clear();
-      dns_info.~ResolveInfo();
       outbound_conn_track_state.clear();
 
       delete[] ranges;

include/proxy/http/PreWarmManager.h

@@ -138,8 +138,7 @@ class PreWarmSM;
 class PreWarmManager;
 class SNIConfigParams;
 
-extern ClassAllocator<PreWarmSM> preWarmSMAllocator;
-extern PreWarmManager            prewarmManager;
+extern PreWarmManager prewarmManager;
 
 /**
    @class PreWarmSM
@@ -230,6 +229,8 @@ class PreWarmSM : public Continuation
   Event          *_retry_event      = nullptr;
 };
 
+extern ClassAllocator<PreWarmSM, false> preWarmSMAllocator;
+
 /**
    @class PreWarmQueue
    @detail

include/proxy/http2/Http2ClientSession.h

@@ -79,4 +79,4 @@ class Http2ClientSession : public ProxySession, public Http2CommonSession
   IpEndpoint cached_local_addr;
 };
 
-extern ClassAllocator<Http2ClientSession, true> http2ClientSessionAllocator;
+extern ClassAllocator<Http2ClientSession> http2ClientSessionAllocator;