Remove eventsystem Inline.cc and cleanup private headers. (#12581)

* Remove eventsystem Inline.cc and cleanup private headers.

* include EThread to get this_ethread

* Fix include in RecProcess.cc

* Remove I_VIO_h

* restore DELAY_FOR_RETRY

---------

Co-authored-by: Chris McFarlen <[email protected]>

Author: cmcfarlen

include/iocore/eventsystem/EThread.h

@@ -710,6 +710,29 @@ operator new(size_t, ink_dummy_for_new *p)
 }
 #define ETHREAD_GET_PTR(thread, offset) ((void *)((char *)(thread) + (offset)))
 
-extern EThread *this_ethread();
+inline EThread *
+this_ethread()
+{
+  return EThread::this_ethread_ptr;
+}
+
+inline EThread *
+this_event_thread()
+{
+  EThread *ethread = this_ethread();
+  if (ethread != nullptr && ethread->tt == REGULAR) {
+    return ethread;
+  } else {
+    return nullptr;
+  }
+}
+
+inline void
+EThread::free_event(Event *e)
+{
+  ink_assert(!e->in_the_priority_queue && !e->in_the_prot_queue);
+  e->mutex = nullptr;
+  EVENT_FREE(e, eventAllocator, this);
+}
 
 extern int thread_max_heartbeat_mseconds;

include/iocore/eventsystem/Event.h

@@ -228,9 +228,18 @@ class Event : public Action
 
   // Private
 
-  Event();
+  Event() : in_the_prot_queue(false), in_the_priority_queue(false), immediate(false), globally_allocated(true), in_heap(false) {}
 
-  Event *init(Continuation *c, ink_hrtime atimeout_at = 0, ink_hrtime aperiod = 0);
+  Event *
+  init(Continuation *c, ink_hrtime atimeout_at = 0, ink_hrtime aperiod = 0)
+  {
+    continuation = c;
+    timeout_at   = atimeout_at;
+    period       = aperiod;
+    immediate    = !period && !atimeout_at;
+    cancelled    = false;
+    return this;
+  }
 
 #ifdef ENABLE_TIME_TRACE
   ink_hrtime start_time;
@@ -282,6 +291,13 @@ class Event : public Action
 //
 extern ClassAllocator<Event> eventAllocator;
 
+inline void
+Event::free()
+{
+  mutex = nullptr;
+  eventAllocator.free(this);
+}
+
 #define EVENT_ALLOC(_a, _t) THREAD_ALLOC(_a, _t)
 #define EVENT_FREE(_p, _a, _t) \
   _p->mutex = nullptr;         \

include/iocore/eventsystem/Freer.h

@@ -52,7 +52,7 @@ template <class C> struct DeleterContinuation : public Continuation {
 //    1. Make sure to schedule a delete on an ET_TASK thread
 //    2. Delay the delete (this should be used sparingly)
 template <class C>
-TS_INLINE void
+void
 new_Deleter(C *ap, ink_hrtime t)
 {
   if (t > 0) {
@@ -78,7 +78,7 @@ template <class C> struct FreeCallContinuation : public Continuation {
 };
 
 template <class C>
-TS_INLINE void
+void
 new_FreeCaller(C *ap, ink_hrtime t)
 {
   eventProcessor.schedule_in(new FreeCallContinuation<C>(ap), t, ET_TASK);
@@ -103,7 +103,7 @@ struct FreerContinuation : public Continuation {
   explicit FreerContinuation(void *ap) : Continuation(nullptr), p(ap) { SET_HANDLER(&FreerContinuation::dieEvent); }
 };
 
-TS_INLINE void
+inline void
 new_Freer(void *ap, ink_hrtime t)
 {
   eventProcessor.schedule_in(new FreerContinuation(ap), t, ET_TASK);
@@ -128,7 +128,7 @@ template <class C> struct DereferContinuation : public Continuation {
 };
 
 template <class C>
-TS_INLINE void
+void
 new_Derefer(C *ap, ink_hrtime t)
 {
   eventProcessor.schedule_in(new DereferContinuation<C>(ap), t, ET_TASK);

include/iocore/eventsystem/IOBuffer.h

@@ -1514,3 +1514,44 @@ IOBufferChain::iterator::operator->() const
 {
   return _b;
 }
+
+//////////////////////////////////////////////////////////////
+//
+// returns 0 for DEFAULT_BUFFER_BASE_SIZE,
+// +1 for each power of 2
+//
+//////////////////////////////////////////////////////////////
+inline int64_t
+buffer_size_to_index(int64_t size, int64_t max)
+{
+  int64_t r = max;
+
+  while (r && BUFFER_SIZE_FOR_INDEX(r - 1) >= size) {
+    r--;
+  }
+  return r;
+}
+
+inline int64_t
+iobuffer_size_to_index(int64_t size, int64_t max)
+{
+  if (size > BUFFER_SIZE_FOR_INDEX(max)) {
+    return BUFFER_SIZE_INDEX_FOR_XMALLOC_SIZE(size);
+  }
+  return buffer_size_to_index(size, max);
+}
+
+inline int64_t
+index_to_buffer_size(int64_t idx)
+{
+  if (BUFFER_SIZE_INDEX_IS_FAST_ALLOCATED(idx)) {
+    return BUFFER_SIZE_FOR_INDEX(idx);
+  } else if (BUFFER_SIZE_INDEX_IS_XMALLOCED(idx)) {
+    return BUFFER_SIZE_FOR_XMALLOC(idx);
+    // coverity[dead_error_condition]
+  } else if (BUFFER_SIZE_INDEX_IS_CONSTANT(idx)) {
+    return BUFFER_SIZE_FOR_CONSTANT(idx);
+  }
+  // coverity[dead_error_line]
+  return 0;
+}

include/iocore/eventsystem/ProtectedQueue.h

@@ -52,3 +52,53 @@ struct ProtectedQueue {
 
   ProtectedQueue();
 };
+
+inline ProtectedQueue::ProtectedQueue()
+{
+  Event e;
+  ink_mutex_init(&lock);
+  ink_atomiclist_init(&al, "ProtectedQueue", (char *)&e.link.next - (char *)&e);
+  ink_cond_init(&might_have_data);
+}
+
+inline void
+ProtectedQueue::signal()
+{
+  // Need to get the lock before you can signal the thread
+  ink_mutex_acquire(&lock);
+  ink_cond_signal(&might_have_data);
+  ink_mutex_release(&lock);
+}
+
+inline int
+ProtectedQueue::try_signal()
+{
+  // Need to get the lock before you can signal the thread
+  if (ink_mutex_try_acquire(&lock)) {
+    ink_cond_signal(&might_have_data);
+    ink_mutex_release(&lock);
+    return 1;
+  } else {
+    return 0;
+  }
+}
+
+// Called from the same thread (don't need to signal)
+inline void
+ProtectedQueue::enqueue_local(Event *e)
+{
+  ink_assert(!e->in_the_prot_queue && !e->in_the_priority_queue);
+  e->in_the_prot_queue = 1;
+  localQueue.enqueue(e);
+}
+
+inline Event *
+ProtectedQueue::dequeue_local()
+{
+  Event *e = localQueue.dequeue();
+  if (e) {
+    ink_assert(e->in_the_prot_queue);
+    e->in_the_prot_queue = 0;
+  }
+  return e;
+}

include/iocore/eventsystem/Thread.h

@@ -107,7 +107,11 @@ class Thread
   */
   Ptr<ProxyMutex> mutex;
 
-  virtual void set_specific() = 0;
+  virtual void
+  set_specific()
+  {
+    this_thread_ptr = this;
+  }
 
   static thread_local Thread *this_thread_ptr;
 
@@ -170,4 +174,8 @@ class Thread
   Thread();
 };
 
-extern Thread *this_thread();
+inline Thread *
+this_thread()
+{
+  return Thread::this_thread_ptr;
+}

include/iocore/eventsystem/VConnection.h

@@ -28,10 +28,6 @@
 #include "tscore/PluginUserArgs.h"
 #include "iocore/eventsystem/EventSystem.h"
 
-#if !defined(I_VIO_h)
-#error "include VIO.h"
-#endif
-
 //
 // Data Types
 //
@@ -145,7 +141,7 @@ typedef struct tsapi_vio *TSVIO;
 class VConnection : public Continuation
 {
 public:
-  ~VConnection() override;
+  ~VConnection() override {}
 
   /**
     Read data from the VConnection.
@@ -306,17 +302,28 @@ class VConnection : public Continuation
   */
   virtual void do_io_shutdown(ShutdownHowTo_t howto) = 0;
 
-  explicit VConnection(ProxyMutex *aMutex);
-  explicit VConnection(Ptr<ProxyMutex> &aMutex);
+  explicit VConnection(ProxyMutex *aMutex) : Continuation(aMutex), lerrno(0) { SET_HANDLER(nullptr); }
+  explicit VConnection(Ptr<ProxyMutex> &aMutex) : Continuation(aMutex), lerrno(0) { SET_HANDLER(nullptr); }
 
   // Private
   // Set continuation on a given vio. The public interface
   // is through VIO::set_continuation()
-  virtual void set_continuation(VIO *vio, Continuation *cont);
+  virtual void
+  set_continuation(VIO *, Continuation *)
+  {
+  }
 
   // Reenable a given vio.  The public interface is through VIO::reenable
-  virtual void reenable(VIO *vio);
-  virtual void reenable_re(VIO *vio);
+  virtual void
+  reenable(VIO *)
+  {
+  }
+
+  virtual void
+  reenable_re(VIO *vio)
+  {
+    reenable(vio);
+  }
 
   /**
     Convenience function to retrieve information from VConnection.
@@ -411,3 +418,32 @@ struct DummyVConnection : public VConnection, public PluginUserArgs<TS_USER_ARGS
 
   explicit DummyVConnection(ProxyMutex *m) : VConnection(m) {}
 };
+
+inline const char *
+get_vc_event_name(int event)
+{
+  switch (event) {
+  default:
+    return "unknown event";
+  case VC_EVENT_NONE:
+    return "VC_EVENT_NONE";
+  case VC_EVENT_IMMEDIATE:
+    return "VC_EVENT_IMMEDIATE";
+  case VC_EVENT_READ_READY:
+    return "VC_EVENT_READ_READY";
+  case VC_EVENT_WRITE_READY:
+    return "VC_EVENT_WRITE_READY";
+  case VC_EVENT_READ_COMPLETE:
+    return "VC_EVENT_READ_COMPLETE";
+  case VC_EVENT_WRITE_COMPLETE:
+    return "VC_EVENT_WRITE_COMPLETE";
+  case VC_EVENT_EOS:
+    return "VC_EVENT_EOS";
+  case VC_EVENT_ERROR:
+    return "VC_EVENT_ERROR";
+  case VC_EVENT_INACTIVITY_TIMEOUT:
+    return "VC_EVENT_INACTIVITY_TIMEOUT";
+  case VC_EVENT_ACTIVE_TIMEOUT:
+    return "VC_EVENT_ACTIVE_TIMEOUT";
+  }
+}