Cleanup and add HttpSM destructor

Author: cmcfarlen

include/proxy/http/HttpSM.h

@@ -187,7 +187,7 @@ class HttpSM : public Continuation, public PluginUserArgs<TS_USER_ARGS_TXN>
 
 public:
   HttpSM();
-  void         cleanup();
+  ~HttpSM() override;
   virtual void destroy();
 
   static HttpSM   *allocate();

include/proxy/http/HttpTransact.h

@@ -849,6 +849,8 @@ class HttpTransact
       //      memset((void *)&host_db_info, 0, sizeof(host_db_info));
     }
 
+    ~State() { destroy(); }
+
     void
     destroy()
     {
@@ -877,7 +879,6 @@ class HttpTransact
       url_map.clear();
       arena.reset();
       unmapped_url.clear();
-      dns_info.~ResolveInfo();
       outbound_conn_track_state.clear();
 
       delete[] ranges;

src/proxy/http/HttpSM.cc

@@ -251,11 +251,8 @@ HttpSM::get_server_connect_timeout()
 
 HttpSM::HttpSM() : Continuation(nullptr), vc_table(this) {}
 
-void
-HttpSM::cleanup()
+HttpSM::~HttpSM()
 {
-  t_state.destroy();
-  api_hooks.clear();
   http_parser_clear(&http_parser);
 
   HttpConfig::release(t_state.http_config_param);
@@ -280,7 +277,6 @@ HttpSM::cleanup()
 void
 HttpSM::destroy()
 {
-  cleanup();
   THREAD_FREE(this, httpSMAllocator, this_thread());
 }
 

src/proxy/http/remap/unit-tests/nexthop_test_stubs.cc

@@ -32,11 +32,10 @@
 #include "proxy/http/HttpSM.h"
 #include "nexthop_test_stubs.h"
 
+int ParentConfig::m_id = 0;
+
 HttpSM::HttpSM() : Continuation(nullptr), vc_table(this) {}
-void
-HttpSM::cleanup()
-{
-}
+HttpSM::~HttpSM() {}
 void
 HttpSM::destroy()
 {