Fix false positive -Wrestrict warning in HttpUserAgent.h with GCC 12 (#12715)

bryancall · web-flow · commit e84ca70ed0a1 · 2025-12-02T14:02:58.000-08:00
GCC 12 produces a false positive -Wrestrict warning when assigning the string literal "-" to std::string in HttpUserAgent::set_txn(). Change to use char literal '-' instead of string literal "-" to avoid the warning, similar to commit 355a9ee.
diff --git a/include/proxy/http/HttpUserAgent.h b/include/proxy/http/HttpUserAgent.h
@@ -178,7 +178,7 @@ HttpUserAgent::set_txn(ProxyTransaction *txn, TransactionMilestones &milestones)
     if (auto group{tbs->get_tls_group()}; !group.empty()) {
       m_conn_info.security_group = group;
     } else {
-      m_conn_info.security_group = "-";
+      m_conn_info.security_group = '-';
     }
 
     if (!m_conn_info.tcp_reused) {

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ HttpUserAgent::set_txn(ProxyTransaction *txn, TransactionMilestones &milestones)`
`178`	`178`	`if (auto group{tbs->get_tls_group()}; !group.empty()) {`
`179`	`179`	`m_conn_info.security_group = group;`
`180`	`180`	`} else {`
`181`		`- m_conn_info.security_group = "-";`
	`181`	`+ m_conn_info.security_group = '-';`
`182`	`182`	`}`
`183`	`183`
`184`	`184`	`if (!m_conn_info.tcp_reused) {`