Add USDT for cache directory insertion and deletion #12688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added license information to the cache_dir_probe.bt file.
bneradt
requested changes
Nov 25, 2025
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks reasonable.
Can we put the test in tests/gold_tests/ats_probe though instead of making a new directory? They seem related enough they can share the same organizing directory.
moonchen
force-pushed
the
usdt-cache-dir
branch
from
5ccd470 to
0ad55ab
Compare
bneradt
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cache directory insert and delete USDT. These will emit the cache directory stripe, segment, segment offset (implying bucket and depth), disk offset, and approx size.
Pass the subclass StripeSM instead of superclass Stripe into helper functions in order to access stripe->fd.
Add an autest for these.