From 1b4d63589139c7f64577c68af98a76f5c848f375 Mon Sep 17 00:00:00 2001 From: Gancho Tenev Date: Mon, 8 May 2017 11:03:30 -0700 Subject: [PATCH] Coverity 1022060: Unchecked return value Problem: CID 1022060 (#1 of 1): Unchecked return value (CHECKED_RETURN) Solution: Added a check for the return value. --- example/cache_scan/cache_scan.cc | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/example/cache_scan/cache_scan.cc b/example/cache_scan/cache_scan.cc index 9172aca7f98..adc1a67daf0 100644 --- a/example/cache_scan/cache_scan.cc +++ b/example/cache_scan/cache_scan.cc @@ -131,15 +131,16 @@ handle_scan(TSCont contp, TSEvent event, void *edata) const char s1[] = "URL: ", s2[] = "\n"; cstate->total_bytes += TSIOBufferWrite(cstate->resp_buffer, s1, sizeof(s1) - 1); TSCacheHttpInfoReqGet(cache_infop, &req_bufp, &req_hdr_loc); - TSHttpHdrUrlGet(req_bufp, req_hdr_loc, &url_loc); - url = TSUrlStringGet(req_bufp, url_loc, &url_len); + if (TS_SUCCESS == TSHttpHdrUrlGet(req_bufp, req_hdr_loc, &url_loc)) { + url = TSUrlStringGet(req_bufp, url_loc, &url_len); - cstate->total_bytes += TSIOBufferWrite(cstate->resp_buffer, url, url_len); - cstate->total_bytes += TSIOBufferWrite(cstate->resp_buffer, s2, sizeof(s2) - 1); + cstate->total_bytes += TSIOBufferWrite(cstate->resp_buffer, url, url_len); + cstate->total_bytes += TSIOBufferWrite(cstate->resp_buffer, s2, sizeof(s2) - 1); - TSfree(url); - TSHandleMLocRelease(req_bufp, req_hdr_loc, url_loc); - TSHandleMLocRelease(req_bufp, TS_NULL_MLOC, req_hdr_loc); + TSfree(url); + TSHandleMLocRelease(req_bufp, req_hdr_loc, url_loc); + TSHandleMLocRelease(req_bufp, TS_NULL_MLOC, req_hdr_loc); + } // print the response headers TSCacheHttpInfoRespGet(cache_infop, &resp_bufp, &resp_hdr_loc);